Make isdispatchtuple consistent for typeof(Union{})
#45348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have `typeof(Union{}) == Type{Union{}}`, but were treating them
differently in the calculation of `isdispatchtuple`. The compiler
expects `isdispatchtuple` to commute with type equality in various
places, so try to make this consistent.
Fixes #45347
vtjnash
approved these changes
May 18, 2022
There was a problem hiding this comment.
We also may be incorrectly failing to normalize this type correctly, since we have
julia> typeof((Union{},)) == Tuple{Type{Union{}}}
true
julia> typeof((Union{},)) === Tuple{Type{Union{}}}
false
julia> typeof((Union{},))
Tuple{Core.TypeofBottom}
Which also violates our assumptions.
pchintalapudi
pushed a commit
that referenced
this pull request
May 25, 2022
We have `typeof(Union{}) == Type{Union{}}`, but were treating them
differently in the calculation of `isdispatchtuple`. The compiler
expects `isdispatchtuple` to commute with type equality in various
places, so try to make this consistent.
Fixes #45347
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
typeof(Union{}) == Type{Union{}}, but were treating themdifferently in the calculation of
isdispatchtuple. The compilerexpects
isdispatchtupleto commute with type equality in variousplaces, so try to make this consistent.
Fixes #45347