fix: lora debug messages removed, fix: download on model hash mismatch, feat: image_is_control, refactors #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tazlin
commented
Jun 21, 2023
•
tazlin
commented
- Removes debug lora messages (e8a084b)
- fix: remove some unneeded logger messages #16
- download on model hash mismatch (9e069b6)
- fix: actually attempt to redownload on hash mismatch #19
- image_is_control (aef4624)
- Fixes lost issue of image_is_control not working #18 (thanks @spinagon!)
- fix: future support for image_is_control for controlnet AI-Horde-Worker#257 supported this change
- More refactos:
- refactor: Improved type hints, various fixes, removes loguru hijacks #22
fix: remove some unneeded logger messages
In the spirit of isolating comfyui imported behavior, which the 3rd party modules ultimately are, this change helps isolate any traps or pitfalls when it comes to importing modules, particularly with pytest.
As covered in my dissertation in `comfy_horde.py` (see diff), this change supports a more flexible scheme allowing pytest discovery to not be so problematic outside of tox.
I have testing in mind when doing this, but there could be other reasons for doing this.
The rationale here is to avoid any tricks to be required re: pytest discovery. The tox test is correspondingly updated
fix: remove rlimit hack from 3rd party module
- `get_mm_pointers` changed for type safety
- `unloadModelManagers` deprecated, replaced by `unload_model_managers ` - `unload_model_managers` expects `Iterable[str | MODEL_CATEGORY_NAMES | type[BaseModelManager]` instead - Better type hints
refactor: Improved type hints, various fixes, removes loguru hijacks
tazlin
changed the title
This was referenced Jun 22, 2023
|
In terms of the horde, only the worker beta branch will be using this version (1.6.x). See Haidra-Org/AI-Horde-Worker#262 as of the time of writing. Other consumers of the library should not experience any irreconcilable problems, as the interfaces should be largely backwards compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.