Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improved type hints, various fixes, removes loguru hijacks #22

Merged
merged 20 commits into from
Jun 22, 2023

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Jun 22, 2023

Of note:

  • loadModelManagers deprecated, replaced by load_model_managers
  • load_model_managers expects Iterable[str | MODEL_CATEGORY_NAMES | type[BaseModelManager] instead of keyword arguments
  • Adhoc LoRa fetch time increased to 45 seconds
  • Utilizes the changes in refactor: better test confinement, fix: backwards compat. with download_all_models() horde-model-reference#29 to use AIWORKER_CACHE_HOME to as the location to store model reference files
  • Removes the loguru hijack's (init_ok, etc). The worker side still has them, and in practice I cannot discern the difference. I know this may be a contentious choice.
  • Better type hints

Everything should be largely backwards compatible if third parties happen to be using this library.

@tazlin tazlin merged commit 483fc08 into main Jun 22, 2023
1 check passed
@tazlin tazlin deleted the more-refactors-noone-asked-for branch June 22, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant