fix: remove rlimit hack from 3rd party module #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the 3rd party annotators were relying on setting rlimits to do... something? It is unclear to me why such a potentially disruptive system change was casually invoked. The offending file was
hordelib\nodes\comfy_controlnet_preprocessors\uniformer\mmseg\datasets\builder.py.Long story short, certain hosted environments, such as runpod, forbid adjusting rlimits. This means certain cloud workers are unable to run hordelib.
See also pytorch/pytorch#973 for some background on the solution I adopted here, which strangely enough is reference in the code removed. I don't have the mental bandwidth to parse the purpose of this module, so it remains to be seen if this change will work in practice.