-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: log ingestion support #4014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanbohan
reviewed
May 27, 2024
shuiyisong
reviewed
May 28, 2024
chore: merge main
sunng87
reviewed
Jun 11, 2024
This was referenced Jun 11, 2024
There are some code and TOM format issues @paomian |
fixed. |
waynexia
reviewed
Jun 13, 2024
paomian
force-pushed
the
feat/log-handler
branch
from
June 13, 2024 06:55
83c0b65
to
db827df
Compare
evenyag
reviewed
Jun 14, 2024
paomian
force-pushed
the
feat/log-handler
branch
from
June 14, 2024 06:59
42d927c
to
7820cd7
Compare
evenyag
reviewed
Jun 14, 2024
evenyag
reviewed
Jun 14, 2024
paomian
force-pushed
the
feat/log-handler
branch
from
June 14, 2024 15:31
5533c8e
to
4433e6c
Compare
evenyag
approved these changes
Jun 14, 2024
killme2008
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's move forward. Other suggestions can be improved in the following PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This pr adds log ingestion support for GreptimeDB.
src/pipeline/src/etl
is a simple implementation of elastic ingest pipelines. We use pipelines to describe ETL process.Feature-wise, this pr includes:
greptime_private
schema)/v1/events/log
http api for ingesting logHow to use
1. Create a pipeline model
or
Use
select * from greptime_private.pipelines;
to check pipeline is successfully created.2. Ingest logs
A
logs1
table is created and log is inserted into the table. Useselect * from logs1;
to confirm.Discussion
v1/event/logs
for ingestion andv1/event/pipelines
for adding pipeline. Should we rename them for better semanticsTODO
Some future works will be done in a separate pr, since it's already a big one.
delete_pipeline
created_at
Content-Type
in ingestion api(likeurlencoded
)etl
mod, namelymod.rs
Checklist