Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipeline): gsub prosessor #4121

Merged
merged 61 commits into from
Jun 17, 2024
Merged

feat(pipeline): gsub prosessor #4121

merged 61 commits into from
Jun 17, 2024

Conversation

yuanbohan
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

implement Elastic Gsub processor

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

paomian and others added 30 commits May 27, 2024 16:51
refactor: use `inserter` instead of `grpc_handler` in pipeline operator
@yuanbohan yuanbohan requested a review from a team as a code owner June 8, 2024 01:13
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 8, 2024
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 82.87671% with 25 lines in your changes missing coverage. Please review.

Project coverage is 84.88%. Comparing base (2faa6d6) to head (233ece0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4121      +/-   ##
==========================================
- Coverage   84.94%   84.88%   -0.06%     
==========================================
  Files        1018     1023       +5     
  Lines      178688   179298     +610     
==========================================
+ Hits       151780   152206     +426     
- Misses      26908    27092     +184     

@shuiyisong
Copy link
Contributor

Wait for #4014 get merged first, then we can add some test.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

src/pipeline/src/etl/processor/gsub.rs Outdated Show resolved Hide resolved
src/pipeline/src/etl/processor/gsub.rs Show resolved Hide resolved
src/pipeline/src/etl/processor/gsub.rs Show resolved Hide resolved
src/pipeline/src/etl/processor/gsub.rs Show resolved Hide resolved
Co-authored-by: dennis zhuang <[email protected]>
@shuiyisong shuiyisong added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 0fc18b6 Jun 17, 2024
50 checks passed
@shuiyisong shuiyisong deleted the gsub-processor branch June 17, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants