CMake: Declare platform libraries to be explicitly static. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libraries declared in CMake using the custom `ADD_PLATFORM_LIBRARY` function are intended for internal consumption by AusweisApp2. These libraries do NOT have a proper so-name, neither get properly installed by CMake, nor header files for integration into external applications are provided. In most of the rpm-based Linux distributions the macroized invocation of CMake assumes any non-explicitly as STATIC or OBJECT declared library to be implicitly built as SHARED. Thus libraries that are intended to be a 'platform' library for the AusweisApp2 application need to be explicitly declared as STATIC. Signed-off-by: Björn Esser <[email protected]>
|
|
The ExternalHttpParser library is built in case the underlying system does not offer a usable HttpParser library. In the previous commit we changed the 'platform' libraries to be explicitly built as STATIC. The reasoning given there applies to this library as well. Signed-off-by: Björn Esser <[email protected]>
|
Thanks for your request! It seems a lot of Linux distributions uses BUILD_SHARED_LIBS=ON today. This is NOT the default of cmake. Just pass "-DBUILD_SHARED_LIBS=OFF" to your build step. (Similar to #24) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libraries declared in CMake using the custom
ADD_PLATFORM_LIBRARYfunction are intended for internal consumption by AusweisApp2. These libraries do NOT have a proper so-name, neither get properly installed by CMake, nor header files for integration into external applications are provided.In most of the rpm-based Linux distributions the macroized invocation of CMake assumes any non-explicitly as STATIC or OBJECT declared library to be implicitly built as SHARED.
Thus libraries that are intended to be a 'platform' library for the AusweisApp2 application need to be explicitly declared as STATIC.