Install SHARED_LIBS #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If SHARED_LIBS get built they also should be installed. Without this patch Gentoo would need an ugly workaround.
|
|
|
👉 View analysis in DeepCode’s Dashboard |
|
Thanks for your contribution. But it seems there is a misunderstanding here. The correct way is to use default settings of cmake which is BUILD_SHARED_LIBS=OFF. Gentoo seems to enable this by default. That's the reason why a previous ebuild disabled it. This was enabled here: https://gitweb.gentoo.org/repo/proj/guru.git/commit/sys-auth/AusweisApp2?id=e484b4e1c95e8fc30d0e33be18e3b7ebe7e8b80e There is no meaning to split the AusweisApp2 in a lot of differrent shared libraries. This is internal stuff only. Do NOT rely on this and do NOT use this. The AusweisApp2 binary is what you want. :-) |
vaukai
referenced
this pull request
in gentoo/guru
Apr 6, 2020
Package-Manager: Portage-2.3.89, Repoman-2.3.20 Signed-off-by: Volkmar W. Pogatzki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If SHARED_LIBS get built they also should be installed.
Without this patch Gentoo would need an ugly workaround.