Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Declare platform libraries to be explicitly static. #26

Closed
wants to merge 2 commits into from
Closed

CMake: Declare platform libraries to be explicitly static. #26

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
266de50
CMake: Declare platform libraries to be explicitly static.
besser82 Jun 24, 2020
500fe66
CMake: Declare the external HttpParser library to be static.
besser82 Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
CMake: Declare the external HttpParser library to be static. 
The ExternalHttpParser library is built in case the underlying system
does not offer a usable HttpParser library.

In the previous commit we changed the 'platform' libraries to be
explicitly built as STATIC.  The reasoning given there applies to this
library as well.

Signed-off-by: Björn Esser <[email protected]>
  • Loading branch information
@besser82
besser82 committed Jun 24, 2020
commit 500fe6620914731fe191bce24148b3d2286e4b25
2 changes: 1 addition & 1 deletion src/external/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ IF(HTTP_PARSER_FOUND)
ELSE()
SET(HTTP_PARSER_INCLUDE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/http_parser")
FILE(GLOB_RECURSE EXTERNAL_HTTP_PARSER_FILES ${HTTP_PARSER_INCLUDE_DIR}/*.cpp)
ADD_LIBRARY(AusweisAppExternalHttpParser ${EXTERNAL_HTTP_PARSER_FILES})
ADD_LIBRARY(AusweisAppExternalHttpParser STATIC ${EXTERNAL_HTTP_PARSER_FILES})
TARGET_INCLUDE_DIRECTORIES(AusweisAppExternalHttpParser INTERFACE "$<BUILD_INTERFACE:${HTTP_PARSER_INCLUDE_DIR}>")

IF(IOS)
Expand Down