Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFT visitor callback order bugs #47

Closed
ChrisRus opened this issue Nov 18, 2015 · 2 comments
Closed

DFT visitor callback order bugs #47

ChrisRus opened this issue Nov 18, 2015 · 2 comments
Assignees
@ChrisRus
Labels
bug
Milestone
v0.7

Comments

@ChrisRus
Copy link
Member

  • treeEdge should not fire before discoverVertex for the edge's target vertex
  • finishEdge callback is not implemented

Noticed some inconsistencies while writing a new DTF-derived visitor algorithm for JBUS vs. my recollection of how the BGL implementation works. Go through this carefully and review.
@ChrisRus ChrisRus added the bug label Nov 18, 2015
@ChrisRus ChrisRus self-assigned this Nov 18, 2015
@ChrisRus ChrisRus added this to the v0.6 milestone Nov 18, 2015
@ChrisRus
Copy link
Member Author

Fixed in 741a72a

@ChrisRus ChrisRus changed the title DTF visitor callback order bugs DFT visitor callback order bugs Nov 18, 2015
@ChrisRus
Copy link
Member Author

Good for 0.6.x release.

ChrisRus added a commit that referenced this issue Nov 18, 2015
@ChrisRus
Merge pull request #46 from Encapsule/chrisrus/develop
53fc9c9 
Chrisrus/develop taking fixes for issues #41 #42 #43 and #47 + a few small doc updates as v0.6.1 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisRus ChrisRus

Labels
bug
Projects
None yet
Milestone
v0.7
Development

No branches or pull requests
1 participant
@ChrisRus