Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty start vector error message #42

Closed
ChrisRus opened this issue Jul 18, 2015 · 1 comment
Closed

Empty start vector error message #42

ChrisRus opened this issue Jul 18, 2015 · 1 comment
Assignees
Milestone

Comments

@ChrisRus
Copy link
Member

For breadth and depth-first traversal, default behavior is to call DirectedGraph.getRootVertices to obtain the start vertex set. Depending on graph topology, this set might be empty resulting in a v0.5.14 errors message:

'''jsgraph.directed.depthFirstTraverse algorithm failure: You have specified an empty starting vertex set for this traversal. This is allowed only if you set request.options.allowEmptyStartVector === true.'''

True, but not really enough to infer back root cause if you happen to dislike reading documentation, forget, or whatever.

Ideas:

We can track if we are taking default behavior or caller override (DirectedGraph.getRootVertices vs. client-provided start vertex set) and make the error message more descriptive:

Set 'request.options.allowEmptyStartVector true or provide a graph that has one or more root vertices, or specify your own start vertex set`

@ChrisRus ChrisRus self-assigned this Jul 18, 2015
@ChrisRus ChrisRus added this to the v0.5.30 milestone Jul 18, 2015
@ChrisRus ChrisRus modified the milestones: v0.6, v0.5.30 Nov 18, 2015
@ChrisRus
Copy link
Member Author

Fixed in 087c864

ChrisRus added a commit that referenced this issue Nov 18, 2015
Chrisrus/develop taking fixes for issues #41 #42 #43 and #47 + a few small doc updates as v0.6.1 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant