Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFT visitor failing to return Boolean error message... #41

Closed
ChrisRus opened this issue Jul 17, 2015 · 1 comment
Closed

DFT visitor failing to return Boolean error message... #41

ChrisRus opened this issue Jul 17, 2015 · 1 comment
Assignees
@ChrisRus
Labels
error handling

Comments

@ChrisRus
Copy link
Member

jsgraph.directed.depthFirstTraverse algorithm failure: BFS visitor.backEdge returned type '[object Number]' instead of expected '[object Boolean]'.

The routine that checks the return type of all visitor interface callback functions is a shared code path now. No need for an algorithm-specific string in the error message: the context is provided when the caller notices the error and adds the outer context to the error.

Drop BFS out above, reset expected results in tests.
@ChrisRus ChrisRus self-assigned this Jul 17, 2015
@ChrisRus ChrisRus added this to the v0.5.30 milestone Jul 18, 2015
@ChrisRus ChrisRus removed the bug label Sep 8, 2015
@ChrisRus
Copy link
Member Author

Fixed in 741a72a

ChrisRus added a commit that referenced this issue Nov 18, 2015
@ChrisRus
Merge pull request #46 from Encapsule/chrisrus/develop
53fc9c9 
Chrisrus/develop taking fixes for issues #41 #42 #43 and #47 + a few small doc updates as v0.6.1 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisRus ChrisRus

Labels
error handling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisRus