Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Drop counter tooltip to be open on click/tap #83

Closed
gsambrotta opened this issue Jun 10, 2021 · 3 comments
Closed

Fix: Drop counter tooltip to be open on click/tap #83

gsambrotta opened this issue Jun 10, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@gsambrotta
Copy link
Collaborator

On the header, near the hamburger menu, we have a little water drop next to the counter of how many liters of water were saved by each user.
If we over on that drop, a tooltip it will show up.
Unfortunately, this shows up even when the menu is open, creating a messy design.

Goal:
Show the tooltip on click or tap
If the menu is open when user click on drop, open the tooltip and close the menu
If the tooltip is open and user click on menu button, close the tooltip.
@gsambrotta gsambrotta added the good first issue Good for newcomers label Jun 10, 2021
@sarahsalder sarahsalder mentioned this issue Jun 28, 2021
Closed
9 tasks
@gsambrotta
Copy link
Collaborator Author

@sarahsalder can you please comment on this issue so I can assign you here?

gsambrotta added a commit that referenced this issue Aug 19, 2021
@gsambrotta
Merged in develop (pull request #83)
b8e2c33 
Develop

* Merged in ssr (pull request #78)

add loading on router changes

* add loading on router changes

* Merged in PagingFix (pull request #79)

Fix paging

* Fix paging

Approved-by: Theophilus Boateng

* Merged in analyze (pull request #80)

Analyze plugin + new video

* add analyze plugin

* add vdeo

* Merged in video-safari (pull request #82)

video with better compression, fix mediaquery addListner for older browsers

* video with better compression, fix mediaquery addListner for older browsers

* Merged in setup-opensource (pull request #81)

Setup opensource

* update readme, API env url

* code of conduct, readme

* update readme, production api url
@1jackdev 1jackdev mentioned this issue Sep 28, 2021
Merged
9 tasks
@gsambrotta
Copy link
Collaborator Author

thank you @1jackdev for your amazing PR! It is now on production 🎉 🎉

@1jackdev
Copy link
Contributor

1jackdev commented Oct 1, 2021

I'm happy to help! Thanks for the feedback

gsambrotta added a commit that referenced this issue Dec 13, 2021
@gsambrotta
Merged in develop (pull request #83)
25f6d81 
Develop

* Merged in ssr (pull request #78)

add loading on router changes

* add loading on router changes

* Merged in PagingFix (pull request #79)

Fix paging

* Fix paging

Approved-by: Theophilus Boateng

* Merged in analyze (pull request #80)

Analyze plugin + new video

* add analyze plugin

* add vdeo

* Merged in video-safari (pull request #82)

video with better compression, fix mediaquery addListner for older browsers

* video with better compression, fix mediaquery addListner for older browsers

* Merged in setup-opensource (pull request #81)

Setup opensource

* update readme, API env url

* code of conduct, readme

* update readme, production api url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsambrotta @1jackdev