Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Terms Page #81

Closed
gsambrotta opened this issue Jun 10, 2021 · 5 comments
Closed

Refactor Terms Page #81

gsambrotta opened this issue Jun 10, 2021 · 5 comments
Assignees
@dazzlerkumar
Labels
good first issue Good for newcomers hacktoberfest PR partecipating to https://hacktoberfest.digitalocean.com/

Comments

@gsambrotta
Copy link
Collaborator

gsambrotta commented Jun 10, 2021 •
edited
Loading

We need to refactor the Term page. Mostly the code but also give a slightly nicer design.
https://elliotforwater.com/terms

Tasks:

  • Make the /terms.tsx page follow the code standard of the rest of the application, using Css Module, remove
    and add proper padding, add .divider under relevant H2.
  • Fix translations: Brings all text to the translation file in locales/ and give to the translation strings proper name.
  • Fix typo where there are any.
  • remove class old_container with a new one, defined in Css Module file.
@gsambrotta gsambrotta added the good first issue Good for newcomers label Jun 10, 2021
gsambrotta added a commit that referenced this issue Aug 19, 2021
@gsambrotta
Merged in develop (pull request #83)
b8e2c33 
Develop

* Merged in ssr (pull request #78)

add loading on router changes

* add loading on router changes

* Merged in PagingFix (pull request #79)

Fix paging

* Fix paging

Approved-by: Theophilus Boateng

* Merged in analyze (pull request #80)

Analyze plugin + new video

* add analyze plugin

* add vdeo

* Merged in video-safari (pull request #82)

video with better compression, fix mediaquery addListner for older browsers

* video with better compression, fix mediaquery addListner for older browsers

* Merged in setup-opensource (pull request #81)

Setup opensource

* update readme, API env url

* code of conduct, readme

* update readme, production api url
@gsambrotta gsambrotta added the hacktoberfest PR partecipating to https://hacktoberfest.digitalocean.com/ label Oct 4, 2021
@dazzlerkumar
Copy link

Assign this to me, I'll try my best to make it readable and beautiful.

@gsambrotta
Copy link
Collaborator Author

Thank you @dazzlerkumar for taking this issue!
I assigned it to you, feel free to tag me directly @gsambrotta if you need any help.

@dazzlerkumar
Copy link

@gsambrotta , Where I can share the screenshots with you? I've made some changes. I want you to see those.

@dazzlerkumar dazzlerkumar mentioned this issue Oct 9, 2021
Closed
13 tasks
@gsambrotta
Copy link
Collaborator Author

@dazzlerkumar feel free to do it here

@gsambrotta
Copy link
Collaborator Author

I'm gonna close this issue since it was done in PR #145

gsambrotta added a commit that referenced this issue Dec 13, 2021
@gsambrotta
Merged in develop (pull request #83)
25f6d81 
Develop

* Merged in ssr (pull request #78)

add loading on router changes

* add loading on router changes

* Merged in PagingFix (pull request #79)

Fix paging

* Fix paging

Approved-by: Theophilus Boateng

* Merged in analyze (pull request #80)

Analyze plugin + new video

* add analyze plugin

* add vdeo

* Merged in video-safari (pull request #82)

video with better compression, fix mediaquery addListner for older browsers

* video with better compression, fix mediaquery addListner for older browsers

* Merged in setup-opensource (pull request #81)

Setup opensource

* update readme, API env url

* code of conduct, readme

* update readme, production api url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dazzlerkumar dazzlerkumar

Labels
good first issue Good for newcomers hacktoberfest PR partecipating to https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsambrotta @dazzlerkumar