Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Privacy Page #82

Closed
gsambrotta opened this issue Jun 10, 2021 · 6 comments
Closed

Refactor Privacy Page #82

gsambrotta opened this issue Jun 10, 2021 · 6 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest PR partecipating to https://hacktoberfest.digitalocean.com/

Comments

@gsambrotta
Copy link
Collaborator

We need to refactor the Term page. Mostly the code but also give a slightly nicer design.
https://elliotforwater.com/privacy

Tasks:

  • Make the /privacy.tsx page follow the code standard of the rest of the application, using Css Module, remove
    and add proper padding, add .divider under relevant H2.
  • Decided where makes sense to use h2, where h3 and where something else based on importance and look of the text/page
  • Fix translations: Brings all text to the translation file in locales/ and give to the translation strings proper name.
  • Fix typo where there are any.
  • remove class old_container with a new one, defined in Css Module file.
@gsambrotta gsambrotta added the good first issue Good for newcomers label Jun 10, 2021
@sarahsalder
Copy link

hi @gsambrotta -- what is meant by "give translation strings proper name"? Is there a new naming convention you want to stick to?

@gsambrotta
Copy link
Collaborator Author

Hey @sarahsalder thanks for the interest!
What I mean is to give a good naming to the string. Right now the translation string in the privacy page are:
privacy:p1, privacy:subtitle2, privacy:p4_a
Would be great, once the text is reformatted, to have a bit more meaningful names, for examples:
privacy:intro_title
privacy:intro_text
privacy:policy

Does this make sense?

gsambrotta added a commit that referenced this issue Aug 19, 2021
Develop

* Merged in ssr (pull request #78)

add loading on router changes

* add loading on router changes

* Merged in PagingFix (pull request #79)

Fix paging

* Fix paging

Approved-by: Theophilus Boateng

* Merged in analyze (pull request #80)

Analyze plugin + new video

* add analyze plugin

* add vdeo

* Merged in video-safari (pull request #82)

video with better compression, fix mediaquery addListner for older browsers

* video with better compression, fix mediaquery addListner for older browsers

* Merged in setup-opensource (pull request #81)

Setup opensource

* update readme, API env url

* code of conduct, readme

* update readme, production api url
@gsambrotta gsambrotta added the hacktoberfest PR partecipating to https://hacktoberfest.digitalocean.com/ label Oct 3, 2021
@jmutt78
Copy link

jmutt78 commented Oct 22, 2021

Hi, I would like to give this one a try

@gsambrotta
Copy link
Collaborator Author

Hi @jmutt78 you are very welcome to pick this one!! Thank you for interest in Elliot.
Maybe can be helpful to you to see this PR: #127
To take inspiration or see some of the comments.
In case you didn't see yet, on our wiki you can find our coding guidelines and contributor workflow.

@jmutt78
Copy link

jmutt78 commented Oct 22, 2021

@gsambrotta sounds good! thank you!

@gsambrotta
Copy link
Collaborator Author

I'm gonna close this issue since it was don ein PR #145

gsambrotta added a commit that referenced this issue Dec 13, 2021
Develop

* Merged in ssr (pull request #78)

add loading on router changes

* add loading on router changes

* Merged in PagingFix (pull request #79)

Fix paging

* Fix paging

Approved-by: Theophilus Boateng

* Merged in analyze (pull request #80)

Analyze plugin + new video

* add analyze plugin

* add vdeo

* Merged in video-safari (pull request #82)

video with better compression, fix mediaquery addListner for older browsers

* video with better compression, fix mediaquery addListner for older browsers

* Merged in setup-opensource (pull request #81)

Setup opensource

* update readme, API env url

* code of conduct, readme

* update readme, production api url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest PR partecipating to https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

No branches or pull requests

3 participants