Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix argument passthrough for sweep #266

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
fix remnant of renaming
  • Loading branch information
derpyplops committed Jul 12, 2023
commit 80507fc182dd817a1d9dbf8ebf750fdf642dd494
1 change: 0 additions & 1 deletion elk/training/sweep.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from datasets import get_dataset_config_info
from transformers import AutoConfig

from ..evaluation import Eval
from ..extraction import Extract
from ..files import memorably_named_dir, sweeps_dir
from ..plotting.visualize import visualize_sweep
Expand Down
4 changes: 2 additions & 2 deletions elk/training/train.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ def create_models_dir(self, out_dir: Path):

def make_eval(self, model, eval_dataset):
Copy link
Collaborator

@lauritowal lauritowal Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if that's the best place to move the code to, everything else looks good to me. 🟢

return Eval(
extract=replace(
self.extract,
data=replace(
self.data,
model=model,
datasets=(eval_dataset,),
),
Expand Down