fix argument passthrough for sweep #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derpyplops
force-pushed
the
not-273-fix-argument-passthrough-for-sweep
branch
from
a8e7bb7
to
84a0426
Compare
This reverts commit f2cdbb1.
for more information, see https://pre-commit.ci
derpyplops
force-pushed
the
not-273-fix-argument-passthrough-for-sweep
branch
from
4b1cc50
to
f7b96b0
Compare
lauritowal
reviewed
Jul 21, 2023
| @@ -48,6 +49,26 @@ def create_models_dir(self, out_dir: Path): | |||
|
|
|||
| return reporter_dir, lr_dir | |||
|
|
|||
| def make_eval(self, model, eval_dataset): | |||
There was a problem hiding this comment.
not sure if that's the best place to move the code to, everything else looks good to me. 🟢
lauritowal
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes not-273