Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix argument passthrough for sweep #266

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix argument passthrough for sweep #266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7dcecf8
fix args passing to sweep
derpyplops Jul 4, 2023
a697d24
remove datasets
derpyplops Jul 4, 2023
aa1dc88
change variable name
derpyplops Jul 10, 2023
0acd41c
move to make_eval
derpyplops Jul 12, 2023
025acb1
Revert "change variable name"
derpyplops Jul 12, 2023
80507fc
fix remnant of renaming
derpyplops Jul 12, 2023
06cb70e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 12, 2023
ea56c63
rename to elicit
derpyplops Jul 12, 2023
9988cc5
remove unnecessary comments
derpyplops Jul 12, 2023
f7b96b0
fix pyright
derpyplops Jul 12, 2023
35c53f5
remove check
derpyplops Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unnecessary comments
  • Loading branch information
@derpyplops
derpyplops committed Jul 12, 2023
commit 9988cc5cc9704ffc453519c9d7b239f010cd5f01
1 change: 0 additions & 1 deletion elk/training/sweep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ def execute(self):
continue

assert elicit.out_dir is not None
# TODO we should fix this so that this isn't needed

eval = elicit.make_eval(model, eval_dataset)
eval.execute(highlight_color="green")
Expand Down
3 changes: 1 addition & 2 deletions elk/training/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ def make_eval(self, model, eval_dataset):
skip_supervised=self.supervised == "none",
prompt_indices=self.prompt_indices,
concatenated_layer_offset=self.concatenated_layer_offset,
# datasets=run.datasets isn't needed because it's
# immediately overwritten
# datasets isn't needed because it's immediately overwritten
debug=self.debug,
disable_cache=self.disable_cache,
)
Expand Down