Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor internal frame tracking & time handling #29

Merged
merged 19 commits into from
Sep 29, 2023
Merged

Refactor internal frame tracking & time handling #29

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e289b67
rework FrameTracker to consistently trigger on next frame
DavidVollmers Sep 27, 2023
cabef59
use new FrameTracker implementation
DavidVollmers Sep 27, 2023
46957cc
remove unnecessary difference between server & client side frame trac…
DavidVollmers Sep 27, 2023
010cfaf
listbox in dialog test
DavidVollmers Sep 27, 2023
9a8da89
prettier
DavidVollmers Sep 27, 2023
ba286e1
ci & cd (install .net 6 & 7)
DavidVollmers Sep 27, 2023
86a1e0d
try CI on windows
DavidVollmers Sep 27, 2023
67478b2
disable prettier check on windows CI
DavidVollmers Sep 27, 2023
0fc3b21
fix prettier check on windows CI
DavidVollmers Sep 27, 2023
5fda6e3
switch CI back to ubuntu-latest & stop using Task.Delay to wait on st…
DavidVollmers Sep 27, 2023
7431aeb
use TimeProvider instead of Task.Delay for transitions
DavidVollmers Sep 28, 2023
64e768d
use TimeProvider instead of Task.Delay
DavidVollmers Sep 29, 2023
1952628
code format
DavidVollmers Sep 29, 2023
4e681ee
update tests to use TestTimeProvider
DavidVollmers Sep 29, 2023
8f23f3a
fixes
DavidVollmers Sep 29, 2023
ea63ca3
introduce ITimer interface
DavidVollmers Sep 29, 2023
daffab1
code format
DavidVollmers Sep 29, 2023
010017b
TestTimer implementation
DavidVollmers Sep 29, 2023
39185e5
fix tests
DavidVollmers Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
use new FrameTracker implementation
  • Loading branch information
@DavidVollmers
DavidVollmers committed Sep 27, 2023
commit cabef598f1a35eda44ccb049e4891e651034489e
6 changes: 3 additions & 3 deletions packages/Ignis.Components/FrameTracker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public void ExecuteOnNextFrame(IgnisComponentBase target, Action action)
{
_target = target ?? throw new ArgumentNullException(nameof(target));
_action = action ?? throw new ArgumentNullException(nameof(action));

// If we're server-side, we can just execute the action on the next render, otherwise we need to wait for the second render. (WebAssembly)
_frameToExecuteOn = _currentFrame + (_hostContext.IsServerSide ? 1 : 2);
}
Expand All @@ -30,7 +30,7 @@ public void OnAfterRender()
if (_currentFrame >= _frameToExecuteOn)
{
_frameToExecuteOn = null;

_action?.Invoke();

_action = null;
Expand All @@ -39,7 +39,7 @@ public void OnAfterRender()
{
_target?.Update();
}

++_currentFrame;
}
}
4 changes: 2 additions & 2 deletions packages/Tailwind/Ignis.Components.HeadlessUI/Dialog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public void Open(Action? continueWith = null)

var __ = IsOpenChanged.InvokeAsync(_isOpen = true);

if (continueWith != null) FrameTracker.ExecuteOnNextFrame(continueWith, Update);
if (continueWith != null) FrameTracker.ExecuteOnNextFrame(this, continueWith);

Update();
}
Expand All @@ -206,7 +206,7 @@ private void CloseCore(Action? continueWith, bool async = false)
{
var __ = IsOpenChanged.InvokeAsync(_isOpen = false);

if (continueWith != null) FrameTracker.ExecuteOnNextFrame(continueWith, Update);
if (continueWith != null) FrameTracker.ExecuteOnNextFrame(this, continueWith);

Update(async);
}
Expand Down
6 changes: 3 additions & 3 deletions packages/Tailwind/Ignis.Components.HeadlessUI/OpenCloseWithTransitionComponentBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ public void Open(Action? continueWith = null)
_ = IsOpenChanged.InvokeAsync(_isOpen = true);

if (_transition != null)
FrameTracker.ExecuteOnNextFrame(() => _transition.Show(() => OnAfterOpen(continueWith)), Update);
else if (continueWith != null) FrameTracker.ExecuteOnNextFrame(() => OnAfterOpen(continueWith), Update);
FrameTracker.ExecuteOnNextFrame(this, () => _transition.Show(() => OnAfterOpen(continueWith)));
else if (continueWith != null) FrameTracker.ExecuteOnNextFrame(this, () => OnAfterOpen(continueWith));

Update();
}
Expand Down Expand Up @@ -73,7 +73,7 @@ private void CloseCore(Action? continueWith, bool async = false)
{
_ = IsOpenChanged.InvokeAsync(_isOpen = false);

if (continueWith != null) FrameTracker.ExecuteOnNextFrame(continueWith, Update);
if (continueWith != null) FrameTracker.ExecuteOnNextFrame(this, continueWith);

Update(async);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/Tailwind/Ignis.Components.HeadlessUI/TransitionBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ private void UpdateState(TransitionState state, Action? continueWith)

_state = state;

if (continueWith != null) FrameTracker.ExecuteOnNextFrame(continueWith, Update);
if (continueWith != null) FrameTracker.ExecuteOnNextFrame(this, continueWith);

Update(async: true);
}
Expand Down