Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internal frame tracking & time handling #29

Merged
merged 19 commits into from
Sep 29, 2023

Conversation

DavidVollmers
Copy link
Owner

This PR refactors the internal FrameTracker class to have consistent frame tracking available for all components.
This PR also introduces a small implementation of the future .NET 8 TimeProvider class and the ITimer interface to not rely on Task.Delay anymore.

This fixes a couple of problems when combining multiple Transition, TransitionChild and other opening/closing components (e.g. Listbox or Dialog).

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (68ee70c) 38.72% compared to head (39185e5) 43.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   38.72%   43.42%   +4.69%     
==========================================
  Files          75       77       +2     
  Lines        2577     2593      +16     
==========================================
+ Hits          998     1126     +128     
+ Misses       1579     1467     -112     
Files Coverage Δ
packages/Ignis.Components/FrameTracker.cs 100.00% <100.00%> (+11.11%) ⬆️
...kages/Ignis.Components/IgnisComponentExtensions.cs 56.60% <100.00%> (+0.83%) ⬆️
...ges/Tailwind/Ignis.Components.HeadlessUI/Dialog.cs 75.26% <100.00%> (-2.16%) ⬇️
...HeadlessUI/OpenCloseWithTransitionComponentBase.cs 80.00% <100.00%> (+22.85%) ⬆️
...Tailwind/Ignis.Components.HeadlessUI/Transition.cs 95.96% <100.00%> (+4.83%) ⬆️
packages/Ignis.Components/TimeProvider.cs 0.00% <0.00%> (ø)
...wind/Ignis.Components.HeadlessUI/TransitionBase.cs 93.13% <96.66%> (+1.09%) ⬆️
packages/Ignis.Components/TimerImplementation.cs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavidVollmers DavidVollmers merged commit 76a3ea4 into master Sep 29, 2023
9 checks passed
@DavidVollmers DavidVollmers deleted the bugfix/listbox-in-dialog branch September 29, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant