-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/explore/group/{group}.json
output shows repeated taxa (EYA broken pagination)
#467
Comments
/explore/group/{group}.json
output shows repeated taxa/explore/group/{group}.json
output shows repeated taxa (EYA broken pagination)
Additionally reported in helpdesk tickets 111246, 111339 and 111354. 111421 |
This looks fixed to me in the test environment. Can someone else verify ? |
Not fixed for me on https://biocache-dq-test.ala.org.au/explore/your-area#-35.2730|149.1163|12|Birds Sort order is broken after entry #50 in list (count should be decreasing but is random). |
@adam-collins pointed out that EYA is not sending the correct |
Hubs is sending inconsistent |
|
@adam-collins - with a minor fix in hubs, this is now working as expected for the default sort order |
Fix for incorrect sort param for subsequent (paginated) calls for the species list column in EYA.
Can someone pls code review the commit above? |
AtlasOfLivingAustralia/biocache-service#663 fixes |
UI fix (ala-hub) deployed to test site. All bugs appear to be fixed. Can someone else check this please? |
these 2 queries return exactly same content which is not expected. Sorry my fault, it's the production url |
* #379 Records from DigiVol don't show "Flag an issue" button * updated version to 3.0.3-SNAPSHOT for next iteration * Feature/duplicate record (#429) Add duplicate assertion type to flag an issue * enhanced duplicate record flag (#431) * release 3.0.3 (#432) * version to 3.0.4-SNAPSHOT * #434 fix duplicate record facet labels Code formatting * Feature my annotation (#435) * allow user to subscribe to 'my annotation' alert when flagging an issue * Fix jquery.i18n load errors * $.param() doesn't format object correctly (#438) * Release/3.0.4 (#442) * 3.0.5-SNAPSHOT * #443 fixes for flash.message exposing apiKey * Revert "Fix jquery.i18n load errors" * Translation of Map legend button and pagination next and previous button * release 3.0.5 (#449) * 3.0.6-SNAPSHOT * AtlasOfLivingAustralia/la-pipelines#372 hide passed assertions by default * i18n en differentiate between duplicate_status and duplicate_type * Bugfix/la pipelines 445 dq profile category dialog display (#456) * AtlasOfLivingAustralia/la-pipelines#445 process array of filters rather then combined filter * AtlasOfLivingAustralia/la-pipelines#445 increase width of DQ profile modal * AtlasOfLivingAustralia/la-pipelines#372 removed test for data quality assertion code `1` * Fix for AtlasOfLivingAustralia/la-pipelines/issues/467 Fix for incorrect sort param for subsequent (paginated) calls for the species list column in EYA. * update biocache-hubs since backend now returns 404 when no record found. * Update README.md * fixed an issue in reading local json files * border-radius for active filters (#462) * wrap taxon name with "" * removed log code * clean log * AtlasOfLivingAustralia/la-pipelines#419 (#465) pass filters and descriptions as JSON array standardise display of filters for DQ profile and category * Release/3.0.6 (#468) * 3.0.7-SNAPSHOT * no strip . in taxon (#469) * handle the case where taxa query returns empty JSON object (404) (#472) * make 'disableAll' and 'expand' configurable (#473) * make 'disableAll' and 'expand' configurable * when 'quality profile' is changed, update drop-down immediately (#474) * use 'fa' for font-awesome 4.x * Issue 470 refine state selection (#476) advanced search UI refine: state list be populated per country selected * style changes to admin page for dq admin link (#477) * fixed a type in flag an issue error message (#478) * added sound file metadata and sound file link to record detail page. (#479) * explicitly set 'user_facets' as String in cookie (#480) * updated css style for #occurrenceSounds * updated message.properties * location display logic updated (#485) * Avh issue120 avh styling (#487) * remove some inline styles * updated left side panel dq filters display * fix the 'view excluded records' on left side panel doesn't work issue. * fix the 'filter details' not shown on left side panel issue * style change, left side panel dq spin * Issue 334 update ehcache (#488) updated to ehcache 3.0 * updated getJsonElements to handle JSON error better (#490) * removed persistence settings * release 3.0.7 Co-authored-by: Rita Chen <[email protected]> Co-authored-by: Nick dos Remedios <[email protected]> Co-authored-by: vjrj <[email protected]> Co-authored-by: alice.ainsa <[email protected]> Co-authored-by: Dave Martin <[email protected]> Co-authored-by: Bruce Hyslop <[email protected]> Co-authored-by: adam-collins <[email protected]>
* #379 Records from DigiVol don't show "Flag an issue" button * updated version to 3.0.3-SNAPSHOT for next iteration * Feature/duplicate record (#429) Add duplicate assertion type to flag an issue * enhanced duplicate record flag (#431) * release 3.0.3 (#432) * version to 3.0.4-SNAPSHOT * #434 fix duplicate record facet labels Code formatting * Feature my annotation (#435) * allow user to subscribe to 'my annotation' alert when flagging an issue * Fix jquery.i18n load errors * $.param() doesn't format object correctly (#438) * Release/3.0.4 (#442) * 3.0.5-SNAPSHOT * #443 fixes for flash.message exposing apiKey * Revert "Fix jquery.i18n load errors" * Translation of Map legend button and pagination next and previous button * release 3.0.5 (#449) * 3.0.6-SNAPSHOT * AtlasOfLivingAustralia/la-pipelines#372 hide passed assertions by default * i18n en differentiate between duplicate_status and duplicate_type * Bugfix/la pipelines 445 dq profile category dialog display (#456) * AtlasOfLivingAustralia/la-pipelines#445 process array of filters rather then combined filter * AtlasOfLivingAustralia/la-pipelines#445 increase width of DQ profile modal * AtlasOfLivingAustralia/la-pipelines#372 removed test for data quality assertion code `1` * Fix for AtlasOfLivingAustralia/la-pipelines/issues/467 Fix for incorrect sort param for subsequent (paginated) calls for the species list column in EYA. * update biocache-hubs since backend now returns 404 when no record found. * Update README.md * fixed an issue in reading local json files * border-radius for active filters (#462) * wrap taxon name with "" * removed log code * clean log * AtlasOfLivingAustralia/la-pipelines#419 (#465) pass filters and descriptions as JSON array standardise display of filters for DQ profile and category * Release/3.0.6 (#468) * 3.0.7-SNAPSHOT * no strip . in taxon (#469) * handle the case where taxa query returns empty JSON object (404) (#472) * make 'disableAll' and 'expand' configurable (#473) * make 'disableAll' and 'expand' configurable * when 'quality profile' is changed, update drop-down immediately (#474) * use 'fa' for font-awesome 4.x * Issue 470 refine state selection (#476) advanced search UI refine: state list be populated per country selected * style changes to admin page for dq admin link (#477) * fixed a type in flag an issue error message (#478) * added sound file metadata and sound file link to record detail page. (#479) * explicitly set 'user_facets' as String in cookie (#480) * updated css style for #occurrenceSounds * updated message.properties * location display logic updated (#485) * Avh issue120 avh styling (#487) * remove some inline styles * updated left side panel dq filters display * fix the 'view excluded records' on left side panel doesn't work issue. * fix the 'filter details' not shown on left side panel issue * style change, left side panel dq spin * Issue 334 update ehcache (#488) updated to ehcache 3.0 * updated getJsonElements to handle JSON error better (#490) * removed persistence settings * release 3.0.7 (#493) * 3.0.8-SNAPSHOT * the converted value should be put back to map to be used somewhere else * updated 'exclude count' font style * release 3.0.8 Co-authored-by: Rita Chen <[email protected]> Co-authored-by: Nick dos Remedios <[email protected]> Co-authored-by: vjrj <[email protected]> Co-authored-by: alice.ainsa <[email protected]> Co-authored-by: Dave Martin <[email protected]> Co-authored-by: Bruce Hyslop <[email protected]> Co-authored-by: adam-collins <[email protected]>
Fix for incorrect sort param for subsequent (paginated) calls for the species list column in EYA.
Fix for incorrect sort param for subsequent (paginated) calls for the species list column in EYA.
Bug reported by a user - https://support.ehelp.edu.au/a/tickets/111300.
When scrolling through list of species in EYA, the list is paginated at 50 items and user can extend the list by clicking on the "show more species" link at end of the list.
The list of taxa is generated from this following call (first 50 items)
https://biocache-ws.ala.org.au/ws/explore/group/Birds.json?lat=-35.2513&lon=149.1635&radius=5&fq=geospatial_kosher%3Atrue&qc=&sort=count&pageSize=50
Clicking the "show more species" link, calls the same service but adds
&start=50
to the request:https://biocache-ws.ala.org.au/ws/explore/group/Birds.json?lat=-35.2513&lon=149.1635&radius=5&fq=geospatial_kosher%3Atrue&start=50&common=false&sort=index&pageSize=50&qc=
The problem is that taxa in the first 50 are reappearing in subsequent paginated requests, when
&start=50
is added. E.g. item 2 from the second call is already present as item 34 in the first call. SO the users sees the same species appearing over and over in the list.Requesting the 3rd, 4th and subsequent pages, simply returns the same results as page 2, e.g.
https://biocache-ws.ala.org.au/ws/explore/group/Birds.json?lat=-35.2513&lon=149.1635&radius=5&fq=geospatial_kosher%3Atrue&start=100&common=false&sort=index&pageSize=50&qc=
is the same as the link above it.
It also seems that the sorting is broken when
start
is provided, as thecount
values should decrease but they are completely inconsistent:1, 3317, 9435, 1, etc.
and items appear to be sorted by taxon name.The text was updated successfully, but these errors were encountered: