Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display of data quality profile category broken #445

Closed
brucehyslop opened this issue Jun 24, 2021 · 11 comments
Closed

Display of data quality profile category broken #445

brucehyslop opened this issue Jun 24, 2021 · 11 comments
Assignees
@brucehyslop
Labels
biocache-hub Issues related to Biocache Hub bug Something isn't working

Comments

@brucehyslop
Copy link

The display of the profile category does not function if the filter contains multiple query terms.

Screen Shot 2021-06-24 at 5.46.39 pm.png
@brucehyslop brucehyslop added the biocache-hub Issues related to Biocache Hub label Jun 24, 2021
@javier-molina javier-molina added the bug Something isn't working label Jun 24, 2021
brucehyslop added a commit to AtlasOfLivingAustralia/biocache-hubs that referenced this issue Jun 25, 2021
@brucehyslop
AtlasOfLivingAustralia/la-pipelines#445 process array of filters rath…
4b5eabe 
…er then combined filter
brucehyslop added a commit to AtlasOfLivingAustralia/biocache-hubs that referenced this issue Jun 25, 2021
@brucehyslop
AtlasOfLivingAustralia/la-pipelines#445 increase width of DQ profile …
c203cba 
…modal
@brucehyslop brucehyslop mentioned this issue Jun 25, 2021
Merged
alexhuang091 pushed a commit to AtlasOfLivingAustralia/biocache-hubs that referenced this issue Jun 25, 2021
@brucehyslop
Bugfix/la pipelines 445 dq profile category dialog display (#456)
ba4d087 
* AtlasOfLivingAustralia/la-pipelines#445 process array of filters rather then combined filter

* AtlasOfLivingAustralia/la-pipelines#445 increase width of DQ profile modal
@adam-collins
Copy link

The display has additional issues:

@adam-collins adam-collins mentioned this issue Jun 28, 2021
Closed
@javier-molina
Copy link

Thanks @adam-collins , the items below are still work in progress and are being addressed as we speak.

@javier-molina
Copy link

Related issues #419 #456 have to be released together.

@javier-molina
Copy link

@adam-collins any further comment re: code changes or review in general, see comment above for how this needs to be tested.

@alexhuang091
Copy link

alexhuang091 commented Jul 13, 2021 •
edited

issue
filter value is broken @brucehyslop

@alexhuang091
Copy link

And I remember there are explanations/links for userAssertions 50001 and 50005. Can they be put here?

2

@nickdos
Copy link

nickdos commented Jul 13, 2021

@javier-molina should this move back to "in progress" to fix the missing values highlighted in the comment above?

@javier-molina javier-molina mentioned this issue Jul 13, 2021
Closed
@brucehyslop
Copy link
Author

Issues relating to the display of DQ filters and links are covered in #419

@brucehyslop
Copy link
Author

brucehyslop commented Aug 19, 2021 •
edited

The reason the links for userAssertions are not displaying on test is because there are no records with userAssertions all Solr shards. The link data relies on a request to biocache-service to retrieve the index field data.

https://biocache-ws-test.ala.org.au/ws/index/fields?fl=userAssertions

This endpoint triggers a Solr LUKE request which queries a single shard. If that shard that is chosen does have records that contain a field the field on not returned.

The links will be displayed sporadically depending on which shard is chosen.

Screen Shot 2021-08-19 at 3 26 12 pm

@brucehyslop
Copy link
Author

The issue does not occur in production because records that contain userAssertions are distributed across all shards.

@brucehyslop
Copy link
Author

The this is the same reason there is no link displayed for outlierLayerCount however this is because sampling on not being run on test.

The link does display on prod.

alexhuang091 added a commit to AtlasOfLivingAustralia/biocache-hubs that referenced this issue Sep 7, 2021
@alexhuang091 @Rita-C
@nickdos @vjrj @djtfmartin @brucehyslop @adam-collins
Release/3.0.7 (#494)
fe99197 
* #379 Records from DigiVol don't show "Flag an issue" button

* updated version to 3.0.3-SNAPSHOT for next iteration

* Feature/duplicate record (#429)

Add duplicate assertion type to flag an issue

* enhanced duplicate record flag (#431)

* release 3.0.3 (#432)

* version to 3.0.4-SNAPSHOT

* #434 fix duplicate record facet labels

Code formatting

* Feature my annotation (#435)

* allow user to subscribe to 'my annotation' alert when flagging an issue

* Fix jquery.i18n load errors

* $.param() doesn't format object correctly (#438)

* Release/3.0.4 (#442)

* 3.0.5-SNAPSHOT

* #443 fixes for flash.message exposing apiKey

* Revert "Fix jquery.i18n load errors"

* Translation of Map legend button and pagination next and previous button

* release 3.0.5 (#449)

* 3.0.6-SNAPSHOT

* AtlasOfLivingAustralia/la-pipelines#372 hide passed assertions by default

* i18n en differentiate between duplicate_status and duplicate_type

* Bugfix/la pipelines 445 dq profile category dialog display (#456)

* AtlasOfLivingAustralia/la-pipelines#445 process array of filters rather then combined filter

* AtlasOfLivingAustralia/la-pipelines#445 increase width of DQ profile modal

* AtlasOfLivingAustralia/la-pipelines#372 removed test for data quality assertion code `1`

* Fix for AtlasOfLivingAustralia/la-pipelines/issues/467

Fix for incorrect sort param for subsequent (paginated) calls for the species list column in EYA.

* update biocache-hubs since backend now returns 404 when no record found.

* Update README.md

* fixed an issue in reading local json files

* border-radius for active filters (#462)

* wrap taxon name with ""

* removed log code

* clean log

* AtlasOfLivingAustralia/la-pipelines#419 (#465)

pass filters and descriptions as JSON array
standardise display of filters for DQ profile and category

* Release/3.0.6 (#468)

* 3.0.7-SNAPSHOT

* no strip . in taxon (#469)

* handle the case where taxa query returns empty JSON object (404) (#472)

* make 'disableAll' and 'expand' configurable (#473)

* make 'disableAll' and 'expand' configurable

* when 'quality profile' is changed, update drop-down immediately (#474)

* use 'fa' for font-awesome 4.x

* Issue 470 refine state selection (#476)

advanced search UI refine: state list be populated per country selected

* style changes to admin page for dq admin link (#477)

* fixed a type in flag an issue error message (#478)

* added sound file metadata and sound file link to record detail page. (#479)

* explicitly set 'user_facets' as String in cookie (#480)

* updated css style for #occurrenceSounds

* updated message.properties

* location display logic updated (#485)

* Avh issue120 avh styling (#487)

* remove some inline styles

* updated left side panel dq filters display

* fix the 'view excluded records' on left side panel doesn't work issue.

* fix the 'filter details' not shown on left side panel issue

* style change, left side panel dq spin

* Issue 334 update ehcache (#488)

updated to ehcache 3.0

* updated getJsonElements to handle JSON error better (#490)

* removed persistence settings

* release 3.0.7

Co-authored-by: Rita Chen <[email protected]>
Co-authored-by: Nick dos Remedios <[email protected]>
Co-authored-by: vjrj <[email protected]>
Co-authored-by: alice.ainsa <[email protected]>
Co-authored-by: Dave Martin <[email protected]>
Co-authored-by: Bruce Hyslop <[email protected]>
Co-authored-by: adam-collins <[email protected]>
alexhuang091 added a commit to AtlasOfLivingAustralia/biocache-hubs that referenced this issue Sep 8, 2021
@alexhuang091 @Rita-C
@nickdos @vjrj @djtfmartin @brucehyslop @adam-collins
Release/3.0.8 (#498)
471fffb 
* #379 Records from DigiVol don't show "Flag an issue" button

* updated version to 3.0.3-SNAPSHOT for next iteration

* Feature/duplicate record (#429)

Add duplicate assertion type to flag an issue

* enhanced duplicate record flag (#431)

* release 3.0.3 (#432)

* version to 3.0.4-SNAPSHOT

* #434 fix duplicate record facet labels

Code formatting

* Feature my annotation (#435)

* allow user to subscribe to 'my annotation' alert when flagging an issue

* Fix jquery.i18n load errors

* $.param() doesn't format object correctly (#438)

* Release/3.0.4 (#442)

* 3.0.5-SNAPSHOT

* #443 fixes for flash.message exposing apiKey

* Revert "Fix jquery.i18n load errors"

* Translation of Map legend button and pagination next and previous button

* release 3.0.5 (#449)

* 3.0.6-SNAPSHOT

* AtlasOfLivingAustralia/la-pipelines#372 hide passed assertions by default

* i18n en differentiate between duplicate_status and duplicate_type

* Bugfix/la pipelines 445 dq profile category dialog display (#456)

* AtlasOfLivingAustralia/la-pipelines#445 process array of filters rather then combined filter

* AtlasOfLivingAustralia/la-pipelines#445 increase width of DQ profile modal

* AtlasOfLivingAustralia/la-pipelines#372 removed test for data quality assertion code `1`

* Fix for AtlasOfLivingAustralia/la-pipelines/issues/467

Fix for incorrect sort param for subsequent (paginated) calls for the species list column in EYA.

* update biocache-hubs since backend now returns 404 when no record found.

* Update README.md

* fixed an issue in reading local json files

* border-radius for active filters (#462)

* wrap taxon name with ""

* removed log code

* clean log

* AtlasOfLivingAustralia/la-pipelines#419 (#465)

pass filters and descriptions as JSON array
standardise display of filters for DQ profile and category

* Release/3.0.6 (#468)

* 3.0.7-SNAPSHOT

* no strip . in taxon (#469)

* handle the case where taxa query returns empty JSON object (404) (#472)

* make 'disableAll' and 'expand' configurable (#473)

* make 'disableAll' and 'expand' configurable

* when 'quality profile' is changed, update drop-down immediately (#474)

* use 'fa' for font-awesome 4.x

* Issue 470 refine state selection (#476)

advanced search UI refine: state list be populated per country selected

* style changes to admin page for dq admin link (#477)

* fixed a type in flag an issue error message (#478)

* added sound file metadata and sound file link to record detail page. (#479)

* explicitly set 'user_facets' as String in cookie (#480)

* updated css style for #occurrenceSounds

* updated message.properties

* location display logic updated (#485)

* Avh issue120 avh styling (#487)

* remove some inline styles

* updated left side panel dq filters display

* fix the 'view excluded records' on left side panel doesn't work issue.

* fix the 'filter details' not shown on left side panel issue

* style change, left side panel dq spin

* Issue 334 update ehcache (#488)

updated to ehcache 3.0

* updated getJsonElements to handle JSON error better (#490)

* removed persistence settings

* release 3.0.7 (#493)

* 3.0.8-SNAPSHOT

* the converted value should be put back to map to be used somewhere else

* updated 'exclude count' font style

* release 3.0.8

Co-authored-by: Rita Chen <[email protected]>
Co-authored-by: Nick dos Remedios <[email protected]>
Co-authored-by: vjrj <[email protected]>
Co-authored-by: alice.ainsa <[email protected]>
Co-authored-by: Dave Martin <[email protected]>
Co-authored-by: Bruce Hyslop <[email protected]>
Co-authored-by: adam-collins <[email protected]>
djtfmartin pushed a commit to AtlasOfLivingAustralia/biocache-hubs that referenced this issue Dec 9, 2021
@brucehyslop @djtfmartin
Bugfix/la pipelines 445 dq profile category dialog display (#456)
4ba7201 
* AtlasOfLivingAustralia/la-pipelines#445 process array of filters rather then combined filter

* AtlasOfLivingAustralia/la-pipelines#445 increase width of DQ profile modal
djtfmartin pushed a commit to AtlasOfLivingAustralia/biocache-hubs that referenced this issue Dec 9, 2021
@brucehyslop @djtfmartin
Bugfix/la pipelines 445 dq profile category dialog display (#456)
69bf485 
* AtlasOfLivingAustralia/la-pipelines#445 process array of filters rather then combined filter

* AtlasOfLivingAustralia/la-pipelines#445 increase width of DQ profile modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brucehyslop brucehyslop

Labels
biocache-hub Issues related to Biocache Hub bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nickdos @adam-collins @javier-molina @brucehyslop @alexhuang091