Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly set 'user_facets' as String in cookie #480

Merged
merged 1 commit into from
Aug 23, 2021
Merged

explicitly set 'user_facets' as String in cookie #480

merged 1 commit into from
Aug 23, 2021

Conversation

alexhuang091
Copy link
Contributor

fix for issue #453

the issue can be reproduced this way:

  1. expand/collspase data-quality profile details
  2. go to 'Customise filters', make whatever changes and click 'Update'

The issue is, in step 1, the $.cookie.json is set to true so cookies values are jsonfied.
Then in step 2, Javascropt string array is jsonfiled which is not what we want.

The fix is to set $.cookie.json = false before setting cookie value.

We don't need to worry about cookie read. Because each read function already knows if the value in cookie is JSON object or string.

nickdos
nickdos approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@nickdos nickdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexhuang091 alexhuang091 merged commit 9d213be into develop Aug 23, 2021
@alexhuang091 alexhuang091 deleted the issue_453_invalid_facets_saved_into_cookie branch August 23, 2021 03:33
alexhuang091 added a commit that referenced this pull request Sep 7, 2021
@alexhuang091 @Rita-C
@nickdos @vjrj @djtfmartin @brucehyslop @adam-collins
Release/3.0.7 (#494)
fe99197 
* #379 Records from DigiVol don't show "Flag an issue" button

* updated version to 3.0.3-SNAPSHOT for next iteration

* Feature/duplicate record (#429)

Add duplicate assertion type to flag an issue

* enhanced duplicate record flag (#431)

* release 3.0.3 (#432)

* version to 3.0.4-SNAPSHOT

* #434 fix duplicate record facet labels

Code formatting

* Feature my annotation (#435)

* allow user to subscribe to 'my annotation' alert when flagging an issue

* Fix jquery.i18n load errors

* $.param() doesn't format object correctly (#438)

* Release/3.0.4 (#442)

* 3.0.5-SNAPSHOT

* #443 fixes for flash.message exposing apiKey

* Revert "Fix jquery.i18n load errors"

* Translation of Map legend button and pagination next and previous button

* release 3.0.5 (#449)

* 3.0.6-SNAPSHOT

* AtlasOfLivingAustralia/la-pipelines#372 hide passed assertions by default

* i18n en differentiate between duplicate_status and duplicate_type

* Bugfix/la pipelines 445 dq profile category dialog display (#456)

* AtlasOfLivingAustralia/la-pipelines#445 process array of filters rather then combined filter

* AtlasOfLivingAustralia/la-pipelines#445 increase width of DQ profile modal

* AtlasOfLivingAustralia/la-pipelines#372 removed test for data quality assertion code `1`

* Fix for AtlasOfLivingAustralia/la-pipelines/issues/467

Fix for incorrect sort param for subsequent (paginated) calls for the species list column in EYA.

* update biocache-hubs since backend now returns 404 when no record found.

* Update README.md

* fixed an issue in reading local json files

* border-radius for active filters (#462)

* wrap taxon name with ""

* removed log code

* clean log

* AtlasOfLivingAustralia/la-pipelines#419 (#465)

pass filters and descriptions as JSON array
standardise display of filters for DQ profile and category

* Release/3.0.6 (#468)

* 3.0.7-SNAPSHOT

* no strip . in taxon (#469)

* handle the case where taxa query returns empty JSON object (404) (#472)

* make 'disableAll' and 'expand' configurable (#473)

* make 'disableAll' and 'expand' configurable

* when 'quality profile' is changed, update drop-down immediately (#474)

* use 'fa' for font-awesome 4.x

* Issue 470 refine state selection (#476)

advanced search UI refine: state list be populated per country selected

* style changes to admin page for dq admin link (#477)

* fixed a type in flag an issue error message (#478)

* added sound file metadata and sound file link to record detail page. (#479)

* explicitly set 'user_facets' as String in cookie (#480)

* updated css style for #occurrenceSounds

* updated message.properties

* location display logic updated (#485)

* Avh issue120 avh styling (#487)

* remove some inline styles

* updated left side panel dq filters display

* fix the 'view excluded records' on left side panel doesn't work issue.

* fix the 'filter details' not shown on left side panel issue

* style change, left side panel dq spin

* Issue 334 update ehcache (#488)

updated to ehcache 3.0

* updated getJsonElements to handle JSON error better (#490)

* removed persistence settings

* release 3.0.7

Co-authored-by: Rita Chen <[email protected]>
Co-authored-by: Nick dos Remedios <[email protected]>
Co-authored-by: vjrj <[email protected]>
Co-authored-by: alice.ainsa <[email protected]>
Co-authored-by: Dave Martin <[email protected]>
Co-authored-by: Bruce Hyslop <[email protected]>
Co-authored-by: adam-collins <[email protected]>
alexhuang091 added a commit that referenced this pull request Sep 8, 2021
@alexhuang091 @Rita-C
@nickdos @vjrj @djtfmartin @brucehyslop @adam-collins
Release/3.0.8 (#498)
471fffb 
* #379 Records from DigiVol don't show "Flag an issue" button

* updated version to 3.0.3-SNAPSHOT for next iteration

* Feature/duplicate record (#429)

Add duplicate assertion type to flag an issue

* enhanced duplicate record flag (#431)

* release 3.0.3 (#432)

* version to 3.0.4-SNAPSHOT

* #434 fix duplicate record facet labels

Code formatting

* Feature my annotation (#435)

* allow user to subscribe to 'my annotation' alert when flagging an issue

* Fix jquery.i18n load errors

* $.param() doesn't format object correctly (#438)

* Release/3.0.4 (#442)

* 3.0.5-SNAPSHOT

* #443 fixes for flash.message exposing apiKey

* Revert "Fix jquery.i18n load errors"

* Translation of Map legend button and pagination next and previous button

* release 3.0.5 (#449)

* 3.0.6-SNAPSHOT

* AtlasOfLivingAustralia/la-pipelines#372 hide passed assertions by default

* i18n en differentiate between duplicate_status and duplicate_type

* Bugfix/la pipelines 445 dq profile category dialog display (#456)

* AtlasOfLivingAustralia/la-pipelines#445 process array of filters rather then combined filter

* AtlasOfLivingAustralia/la-pipelines#445 increase width of DQ profile modal

* AtlasOfLivingAustralia/la-pipelines#372 removed test for data quality assertion code `1`

* Fix for AtlasOfLivingAustralia/la-pipelines/issues/467

Fix for incorrect sort param for subsequent (paginated) calls for the species list column in EYA.

* update biocache-hubs since backend now returns 404 when no record found.

* Update README.md

* fixed an issue in reading local json files

* border-radius for active filters (#462)

* wrap taxon name with ""

* removed log code

* clean log

* AtlasOfLivingAustralia/la-pipelines#419 (#465)

pass filters and descriptions as JSON array
standardise display of filters for DQ profile and category

* Release/3.0.6 (#468)

* 3.0.7-SNAPSHOT

* no strip . in taxon (#469)

* handle the case where taxa query returns empty JSON object (404) (#472)

* make 'disableAll' and 'expand' configurable (#473)

* make 'disableAll' and 'expand' configurable

* when 'quality profile' is changed, update drop-down immediately (#474)

* use 'fa' for font-awesome 4.x

* Issue 470 refine state selection (#476)

advanced search UI refine: state list be populated per country selected

* style changes to admin page for dq admin link (#477)

* fixed a type in flag an issue error message (#478)

* added sound file metadata and sound file link to record detail page. (#479)

* explicitly set 'user_facets' as String in cookie (#480)

* updated css style for #occurrenceSounds

* updated message.properties

* location display logic updated (#485)

* Avh issue120 avh styling (#487)

* remove some inline styles

* updated left side panel dq filters display

* fix the 'view excluded records' on left side panel doesn't work issue.

* fix the 'filter details' not shown on left side panel issue

* style change, left side panel dq spin

* Issue 334 update ehcache (#488)

updated to ehcache 3.0

* updated getJsonElements to handle JSON error better (#490)

* removed persistence settings

* release 3.0.7 (#493)

* 3.0.8-SNAPSHOT

* the converted value should be put back to map to be used somewhere else

* updated 'exclude count' font style

* release 3.0.8

Co-authored-by: Rita Chen <[email protected]>
Co-authored-by: Nick dos Remedios <[email protected]>
Co-authored-by: vjrj <[email protected]>
Co-authored-by: alice.ainsa <[email protected]>
Co-authored-by: Dave Martin <[email protected]>
Co-authored-by: Bruce Hyslop <[email protected]>
Co-authored-by: adam-collins <[email protected]>
djtfmartin pushed a commit that referenced this pull request Dec 9, 2021
@alexhuang091 @djtfmartin
explicitly set 'user_facets' as String in cookie (#480)
1306ae5
djtfmartin pushed a commit that referenced this pull request Dec 9, 2021
@alexhuang091 @djtfmartin
explicitly set 'user_facets' as String in cookie (#480)
14bbaa0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickdos nickdos nickdos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexhuang091 @nickdos