Fixed incorrect comparison in ACL module skipping logic #472
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The original code snippet was intended to skip over a module if its ReturnSubType did not match the required ReturnSubType. Due to an error in the condition logic, the module skipping function does not operating as expected.
!$Module->{ReturnSubType}
results in an empty string, that is then checked for equality with$Param{ReturnSubType}
.This code runs only if $Param{ReturnSubType} is given. The result is the same as if a ReturnSubType would not be checked at all and the code runs for every sub type.
Update:
Additionally the
ReturnSubType
can also given as an array of possible sub types, but the condition checks for a hash reference. If it was intended, that the subtype could be given as hash, then the code inside the condition is wrong.Either way, currently none of the restrictions are working.
Checklist