Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling sticking to top #13853

Closed
wants to merge 1 commit into from

Conversation

WeetHet
Copy link
Contributor

@WeetHet WeetHet commented Jul 5, 2024

I've reverted a bunch of stuff from the faulty PR, it seems to fix the problem. I don't know what exactly fixed it and honestly, I don't even care anymore

Fixes #13720.

Release Notes:

  • Fixed scrolling sticking to top and bottom

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 5, 2024
@maxdeviant maxdeviant changed the title Fix #13720 Fix scrolling sticking to top Jul 5, 2024
@maxdeviant
Copy link
Member

I've reverted a bunch of stuff from the faulty PR

What is the faulty PR? Should we revert the whole PR instead of just parts of it?

I don't know what exactly fixed it and honestly, I don't even care anymore

This is not satisfactory. If we don’t understand the problem we can’t be making changes that “fix” it.

@WeetHet
Copy link
Contributor Author

WeetHet commented Jul 5, 2024

I don't know what exactly fixed it and honestly, I don't even care anymore

This is not satisfactory. If we don’t understand the problem we can’t be making changes that “fix” it.

Sure, I don't have time to investigate this even further right now, though, so I'll be closing this PR

@WeetHet WeetHet closed this Jul 5, 2024
@WeetHet WeetHet deleted the fix-sticky-scroll branch July 5, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrolling sticks to top when "cursor_blink": false set
3 participants