-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling sticks to top when "cursor_blink": false
set
#13720
Comments
I can reproduce the scroll sticking independent of the Interestingly this does not occur when I first open a project (e.g. while rust-analyzer loads the zed workspace). Only once rust-analyzer is done indexing does the scroll lag behavior begin. |
I wonder if #11244 that @alygin and @SomeoneToIgnore were discussing is related. |
@notpeter Yes, I think I can too. It's just that it is a tiny delay for me as compared to an unusable near one second delay with |
Okay, so I'm not going insane and scrolling is indeed broken. That is nice to know, I guess. For me, scrolling breaks not only when over-scrolling, but also when I change focused panes or try to scroll a non focused pane. |
I guess we need @as-cii or @rtfeldman help here, because I have no idea what is going on in that pull request |
Continuing on with my investigation, a bug is somewhere in the one of the two files: |
I went and found the exact lines causing the issue: zed/crates/editor/src/element.rs Lines 3660 to 3663 in 9b7bc04
Before #13368 they would execute even if |
Fixes: #13720. Co-authored-by: Antonio Scandurra <[email protected]>
@notpeter could you please reopen this issue, as it is not fixed for me yet (I've compiled zed from your branch and still experience scrolling sticking to the top) |
Fixes: #13720. Co-authored-by: Antonio Scandurra <[email protected]>
The problem seemingly was that scrolling only started after autoscroll has finished. I have added a function to forcefully stop it, which I call when scroll event happens Release Notes: - Fixed delay when changing scrolling direction (#13720) --------- Co-authored-by: Piotr <[email protected]>
I'm with the same problem here on Linux (with the build of the project available on curl), i.e.,
|
Are you on Preview or Stable? |
Stable. The scroll doesn't work at all. Not even clicking the scroll bar |
@ChristoferMendes Can you open a new issue, I believe you are experiencing something distinct from this issue. This is about a delay where scrolling lags temporarily after scrolling to the top of a file. Sounds like your scrolling is completely broken. Separately, the fix for this issue went out in Zed Preview today (thanks @WeetHet for your help with #13874) and will be in Zed Stable next week (2024-07-17). |
Fixes: #13720 Co-Authored-By: <[email protected]>
Fixes: #13720 Co-Authored-By: <[email protected]> Release Notes: - vim: Fixed `gv` after `y`, `d`, etc. ([#13760](#13760)).
Check for existing issues
Describe the bug / provide steps to reproduce it
This is the strangest thing, but just in the last weeks I've noticed that scrolling to the very top of a pane and then attempting to scroll down (via touchpad) results in a delay before scrolling down takes place. It takes multiple times before it reacts and the delay is up to a second. I originally assumed it was something related to my vim settings, but removed all settings except this and still get the behavior...
If I set that to
true
, regardless of settings, the problem disappears.Environment
Zed: v0.142.3 (Zed Preview)
OS: macOS 14.4.1
Memory: 32 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your
~/Library/Logs/Zed/Zed.log
file to this issue.No response
The text was updated successfully, but these errors were encountered: