Allow registering click and value change events after element instantiation #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is totally unrelated to this PR (but very related to my attempts to contribute): i just ran 
|
|
this PR is continued in #2708 |
3 tasks
|
Regarding the autopep8 conflict, I just created a separate issue: #2750. |
* JsonEditor: on_select and on_change builder-style registration * ValueElement: builder pattern for on_value_change * Table: allow multiple on_selection and on_pagination_change handlers via the builder pattern * Tree: allow all Python handlers to be registered more than once via the builder pattern * Keyboard element: support multiple on_key handlers via the builder pattern. * color picker: support multiple on_pick callbacks via builder pattern * list item: support multiple on_click callbacks via builder pattern * MenuItem: support multiple on_click callbacks via builder pattern * Upload: support multiple on_upload & on_rejected callbacks via builder pattern * Scene: support multiple click/drag handlers via builder pattern * ScrollArea: support multiple on_scroll callbacks via builder pattern * EChart: support multiple on_point_click handlers via builder pattern * InteractiveImage: support multiple on_mouse handlers via builder pattern * Joystick: support multiple handlers of each event type via builder pattern * code review --------- Co-authored-by: Falko Schindler <[email protected]>
…to event-registration
rodja
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses feature request #2687, allowing to add event handlers after UI element have been created. It is still work in progress though.