-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autopep8 enforces the maximum line length differently #2750
Comments
one minor add-on question here: would y'all consider introducing something like It's usually quite easy to get a basic pre-commit config set up, and I'd be happy to make the PR (and change the CONTRIBUTING document to let people know that they can install it) |
@petergaultney Yes, there have been attempts towards pre-commit hooks recently (PR #2563 and PR #2619) and we're definitely considering it. But I guess we need to find a "recipe" first, which works on all machines and yields same results like the IDE integration(s) we're recommending to use. |
When I run the autopep8 command without the |
Description
As noticed by @petergaultney in #2704 (comment), the CONTRIBUTING.md file recommends running
autopep8 --max-line-length=120 --experimental --in-place --recursive .
to auto-format the code, which causes quite some changes in the codebase, which is usually formatted with the autopep8 VSCode extension. There are 15 files with too long lines that get wrapped. I tried removing the
--experimental
argument, which doesn't seem to make a difference.--experimental
is supposed to do. Maybe we can remove it.The text was updated successfully, but these errors were encountered: