Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation Easing public으로 변경 #234

Closed
cometj03 opened this issue Dec 27, 2023 · 0 comments · Fixed by #235
Closed

Animation Easing public으로 변경 #234

cometj03 opened this issue Dec 27, 2023 · 0 comments · Fixed by #235

Comments

@cometj03
Copy link
Member

No description provided.

@cometj03 cometj03 mentioned this issue Dec 27, 2023
Merged
cometj03 added a commit that referenced this issue Jan 15, 2024
@cometj03 @Gael-Android
[YDS-#234] YdsEasing public으로 변경 (#235)
cb30c8d 
* feat: YdsInAndOutEasing -> YdsEasing & public

* [YDS-#228] Component - Toast 구현 (#233)

* MyScaffold, Toast 초기 후구현

* 구현 완료

* 리뷰 반영

- 기존 YdsScaffold 대체
- preview 맨 아래로, private 변경
- 기존 다른 파일들도 preview function은 전부 private하게 변경
- 인터페이스, enum 맨 위로
- YdsEasing 사용
- Toast Animation 파일 분리
- 기타 코드 정리

* 리뷰 반영

- 코드수정
- 네이밍 변경
- 주석 작성중.
- 이해완료

* 리뷰 반영

- 패키지 변경
- 최소높이 제거
- 네이밍 변경
- 주석 작성

* 디버그 용 함수 제거

* rememberToastHostState 생성

* ToastDuration Enum애 시간 정의

* 텍스트 가운데 정렬 로직 추가

* rememberToastHost -> ToastHost.kt로 이동

* 오타 수정

* refactor: ToastAnimation의 YdsInAndOutEasing -> YdsEasing

* Resolve conflict

---------

Co-authored-by: Gael-Android <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[YDS-#234] YdsEasing public으로 변경 yourssu/YDS-Android
1 participant
@cometj03