[YDS-#234] YdsEasing public으로 변경 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gael-Android
previously approved these changes
Dec 29, 2023
* MyScaffold, Toast 초기 후구현 * 구현 완료 * 리뷰 반영 - 기존 YdsScaffold 대체 - preview 맨 아래로, private 변경 - 기존 다른 파일들도 preview function은 전부 private하게 변경 - 인터페이스, enum 맨 위로 - YdsEasing 사용 - Toast Animation 파일 분리 - 기타 코드 정리 * 리뷰 반영 - 코드수정 - 네이밍 변경 - 주석 작성중. - 이해완료 * 리뷰 반영 - 패키지 변경 - 최소높이 제거 - 네이밍 변경 - 주석 작성 * 디버그 용 함수 제거 * rememberToastHostState 생성 * ToastDuration Enum애 시간 정의 * 텍스트 가운데 정렬 로직 추가 * rememberToastHost -> ToastHost.kt로 이동 * 오타 수정
coding-polarbear
previously approved these changes
Jan 15, 2024
Gael-Android
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #234