Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Pydantic v2 #94

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Conversation

hongquan
Copy link
Contributor

Fixes #70

What changes:

  • Work with Pydantic v2 (not work with Pydantic v1, due to drastic change in Pydantic API).
  • Raise minimum Python to 3.10, to support Django 5.0

You may notice change in testing data, about how to define "required" field. Look here for how it changed.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (2ffbdf8) 94.82% compared to head (463c7dc) 94.07%.

Files Patch % Lines
pyngo/openapi.py 83.33% 4 Missing ⚠️
pyngo/querydict.py 88.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   94.82%   94.07%   -0.76%     
==========================================
  Files           8        8              
  Lines         232      253      +21     
==========================================
+ Hits          220      238      +18     
- Misses         12       15       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yezz123 yezz123 merged commit 5f6e307 into yezz123:main Jan 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pydantic v2 support?
2 participants