Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic v2 support? #70

Closed
hongquan opened this issue Jul 25, 2023 · 4 comments · Fixed by #94
Closed

Pydantic v2 support? #70

hongquan opened this issue Jul 25, 2023 · 4 comments · Fixed by #94
Assignees
Labels
enhancement New feature or request

Comments

@hongquan
Copy link
Contributor

Pydantic v2 has been released. Do you plan to support it?

@yezz123
Copy link
Owner

yezz123 commented Jul 26, 2023

Pydantic v2 has been released. Do you plan to support it?

Hey @hongquan Yes I will try to open a pull request as soon as i have sometimes, because still have a full backlog of migrations for almost 5/6 packages to Pydantic v2

@yezz123 yezz123 added the enhancement New feature or request label Jul 26, 2023
@talhajunaidd
Copy link

talhajunaidd commented Sep 8, 2023

Hi @yezz123 I can do the migration and create a PR.

Do we want to support both pydantic v1 and pydantic v2?
If yes, could you share some structure/guidelines to support both.

@yezz123
Copy link
Owner

yezz123 commented Sep 9, 2023

Hey, @talhajunaidd That sounds fantastic!

Thank you so much for your willingness to contribute to the project and add support for both Pydantic versions.

Your effort will be greatly appreciated, making the project more accessible to a broader range of users. Please feel free to proceed, and if you have any questions or need assistance along the way, don't hesitate to reach out.

Looking forward to your PR!

( I was busy a lot during these last 2 months that's why I didn't attend to update the codebase for a bunch of projects)

@giulioindev
Copy link

Please can you merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants