Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

App strings reworked #332

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

App strings reworked #332

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d4aeba
App strings reworked
comradekingu Jan 11, 2021
0a06782
Suggested changes made
comradekingu Jan 12, 2021
3be84f8
Removed unused string
comradekingu Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 19 additions & 26 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<string name="fragment_settings_title">Settings</string>
<!-- Dialogs -->
<string name="dialog_edit_choose_station_image">Choose</string>
<string name="dialog_edit_place_on_home_screen">Place on Home screen</string>
<string name="dialog_edit_place_on_home_screen">Place on \"Home\" screen</string>
<string name="dialog_edit_title">Edit Station</string>
<string name="dialog_edit_update_station">Update station</string>
<string name="dialog_error_message_default">An error occurred</string>
Expand Down Expand Up @@ -77,11 +77,11 @@
<string name="pref_maintenance_title">Maintenance</string>
<string name="pref_report_issue_summary">Report bugs and suggest improvements on GitHub.</string>
<string name="pref_report_issue_title">Report Issue</string>
<string name="pref_theme_selection_mode_dark">Dark mode</string>
<string name="pref_theme_selection_mode_dark">Dark</string>
<string name="pref_theme_selection_mode_device_default">Same as device</string>
<string name="pref_theme_selection_mode_light">Light mode</string>
<string name="pref_theme_selection_summary">Current theme:</string>
<string name="pref_theme_selection_title">App Theme</string>
<string name="pref_theme_selection_mode_light">Light</string>
<string name="pref_theme_selection_summary">Current:</string>
<string name="pref_theme_selection_title">Theme</string>
<string name="pref_update_collection_summary">Look for updated audio streams and new station images.</string>
<string name="pref_update_collection_title">Update Stations</string>
<string name="pref_update_station_images_summary">Download latest version of all station images.</string>
Expand All @@ -95,7 +95,7 @@
<string name="descr_card_small_edit_button">Edit</string>
<string name="descr_card_starred_station">Starred station</string>
<string name="descr_card_station_image">Station image</string>
<string name="descr_dialog_edit_place_on_home_screen_icon">Place on Home screen</string>
<string name="descr_dialog_edit_place_on_home_screen_icon">Place on \"Home\" screen</string>
<string name="descr_dialog_edit_station_image">Station image</string>
<string name="descr_dialog_edit_update_icon">Update</string>
<string name="descr_expanded_player_sleep_timer_cancel_button">Cancel sleep timer</string>
Expand All @@ -113,22 +113,15 @@
<!-- Sample Text -->
<string name="sample_text_station_metadata" translatable="false">David Bowie - The Man Who Sold The World</string>
<string name="sample_text_station_name" translatable="false">Byte FM</string>
<string name="sample_text_steam_url" translatable="false">http:https://bytefm.cast.addradio.de/bytefm/main/mid/stream</string>
<string name="sample_text_steam_url" translatable="false">https:https://bytefm.cast.addradio.de/bytefm/main/mid/stream</string>
<string name="sample_text_sleep_timer_remaining_time" translatable="false">00:00</string>
<!-- Allowed Caller Template -->
<string name="allowed_caller_log" translatable="false">
Caller has a valid certificate, but its package doesn\'t match any expected package for the
given certificate. To allow this caller, add the following to the allowed callers list:\n
<![CDATA[
<signature name=\"%1$s\" package=\"%2$s\">\n\t<key>%3$s</key>\n</signature>\n
]]>
</string>
<!-- Allowed Template -->
<!-- Strings from Classic Transistor -->
<!-- please do not translate app_name - transcription into different alphabet types is fine though -->
<!-- app shortcuts -->
<string name="shortcut_last_station_short_label">Last station</string>
<string name="shortcut_last_station_long_label">Play last station</string>
<string name="shortcut_last_station_disabled_message">Shortcut for playback of last station disabled.</string>
<string name="shortcut_last_station_disabled_message">Removed shortcut for playback of last station.</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't great

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

<!-- menu entries -->
<string name="menu_icon">Change icon</string>
<string name="menu_delete">Delete</string>
Expand Down Expand Up @@ -174,20 +167,20 @@
<!-- error dialogs -->
<string name="dialog_error_details_button_default">Show details</string>
<string name="dialog_error_details_default">No details available</string>
<string name="dialog_error_details_write">This station is probably a duplicate or else you might want to check your external storage.</string>
<string name="dialog_error_details_write">Station possibly duplicated.</string>
<string name="dialog_error_title_fetch_download">Download Issue</string>
<string name="dialog_error_title_fetch_read">Read Issue</string>
<string name="dialog_error_title_fetch_write">Write Issue</string>
<string name="dialog_error_message_fetch_general_external_storage">External storage:</string>
<string name="dialog_error_message_fetch_general_hint_m3u">Hint: Transistor can only process MP3, AAC and Ogg/Opus encoded streams or links ending in .m3u or .pls.</string>
<string name="dialog_error_message_fetch_general_hint_m3u">Hint: Transistor can only process MP3, AAC and Ogg Opus encoded streams or links ending in .m3u or .pls.</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://en.wikipedia.org/wiki/Opus_%28audio_format%29

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand the Wikipedia entry the actual data format of such a stream is OPUS and OGG is just a container. If that is the case we could drop "Ogg" completely, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless they actually are delivered as Ogg container streams?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When asked to add an OGG file to the collection of radio stations, Transistor strips out the stream address and does not store the container.

<string name="dialog_error_message_fetch_general_playlist_type">Media type of file:</string>
<string name="dialog_error_message_fetch_general_stream_type">MIME type of stream:</string>
<string name="dialog_error_message_fetch_general_stream_type">Media type of stream:</string>
<string name="dialog_error_message_fetch_general_file_content">Content of file:</string>
<string name="dialog_error_message_fetch_download">Transistor tried hard but could not make sense of the link.</string>
<string name="dialog_error_message_fetch_download">Could not make sense of that link.</string>
<string name="dialog_error_message_fetch_download_station_url">Streaming link of station:</string>
<string name="dialog_error_message_fetch_read">Transistor tried hard but could not make sense of the file.</string>
<string name="dialog_error_message_fetch_read_file_location">Location of file:</string>
<string name="dialog_error_message_fetch_write">Transistor tried hard but could not save the station.</string>
<string name="dialog_error_message_fetch_write">Could not save the station.</string>
<!-- messages -->
<string name="toastmessage_add_download_started">Download started.</string>
<string name="toastmessage_add_open_file_started">Opening file.</string>
Expand All @@ -205,18 +198,18 @@
<string name="toastmessage_timer_cancelled">Sleep timer cancelled.</string>
<string name="toastmessage_timer_duration_increased">Duration increased.</string>
<string name="toastmessage_sleep_timer_unable_to_start">Please start playback first.</string>
<string name="toastalert_unable_to_connect">Unable to connect. Device does not have an internet connection or stream may be outdated.</string>
<string name="toastalert_unable_to_connect">Unable to connect. Device does not have an internet connection or the stream is outdated.</string>
<string name="toastalert_rename_unsuccessful">Unable to rename station. Please choose a different name.</string>
<string name="toastalert_delete_successful">The station was removed.</string>
<string name="toastalert_delete_successful">Station removed.</string>
<string name="toastalert_no_external_storage">Unable to access external storage.</string>
<string name="toastalert_no_image_picker">No image picker available. Consider installing a Gallery application.</string>
<string name="toastalert_no_image_picker">No image picker available. Consider installing a Gallery app.</string>
<string name="toastalert_headphones_unplugged">Headphones unplugged. Playback stopped.</string>
<string name="toastalert_permission_denied">Permission denied:</string>
<string name="toastalert_station_not_found">Unable to find station.</string>
<string name="snackbar_request_storage_access">Transistor needs to be granted read permissions to be able access data from external storage.</string>
<string name="snackbar_request_storage_access">Grant \"Read storage\" permission to access data from external storage.</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just the one permission?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the code level this permission is called "READ_EXTERNAL_STORAGE".

<string name="snackbar_message_timer_set">Sleep timer set to</string>
<!-- notification -->
<string name="notification_stop">Stop</string>
<string name="notification_channel_playback_name">Playback Controls</string>
<string name="notification_channel_playback_description">Playback controls, station logo and now playing info.</string>
</resources>
</resources>