App strings reworked #332
App strings reworked #332
Conversation
| <string name="toastalert_headphones_unplugged">Headphones unplugged. Playback stopped.</string> | ||
| <string name="toastalert_permission_denied">Permission denied:</string> | ||
| <string name="toastalert_station_not_found">Unable to find station.</string> | ||
| <string name="snackbar_request_storage_access">Transistor needs to be granted read permissions to be able access data from external storage.</string> | ||
| <string name="snackbar_request_storage_access">Grant \"Read storage\" permission to access data from external storage.</string> |
There was a problem hiding this comment.
Is this just the one permission?
There was a problem hiding this comment.
On the code level this permission is called "READ_EXTERNAL_STORAGE".
| <string name="dialog_error_title_fetch_download">Download Issue</string> | ||
| <string name="dialog_error_title_fetch_read">Read Issue</string> | ||
| <string name="dialog_error_title_fetch_write">Write Issue</string> | ||
| <string name="dialog_error_message_fetch_general_external_storage">External storage:</string> | ||
| <string name="dialog_error_message_fetch_general_hint_m3u">Hint: Transistor can only process MP3, AAC and Ogg/Opus encoded streams or links ending in .m3u or .pls.</string> | ||
| <string name="dialog_error_message_fetch_general_hint_m3u">Hint: Transistor can only process MP3, AAC and Ogg Opus encoded streams or links ending in .m3u or .pls.</string> |
There was a problem hiding this comment.
There was a problem hiding this comment.
As I understand the Wikipedia entry the actual data format of such a stream is OPUS and OGG is just a container. If that is the case we could drop "Ogg" completely, right?
There was a problem hiding this comment.
Unless they actually are delivered as Ogg container streams?
There was a problem hiding this comment.
When asked to add an OGG file to the collection of radio stations, Transistor strips out the stream address and does not store the container.
app/src/main/res/values/strings.xml
Outdated
| @@ -174,20 +174,20 @@ | |||
| <!-- error dialogs --> | |||
| <string name="dialog_error_details_button_default">Show details</string> | |||
| <string name="dialog_error_details_default">No details available</string> | |||
| <string name="dialog_error_details_write">This station is probably a duplicate or else you might want to check your external storage.</string> | |||
| <string name="dialog_error_details_write">Check your external storage if this station isn't a duplicate.</string> | |||
There was a problem hiding this comment.
What would one check external storage for?
There was a problem hiding this comment.
There could be two reasons why the write fails: 1. Duplicate File 2. External Storage unmounted (unlikely). The string is shown when a user taps on "Show details". In an error dialog. I think "Station is probably a duplicate." might be good here.
| @@ -128,7 +128,7 @@ | |||
| <!-- app shortcuts --> | |||
| <string name="shortcut_last_station_short_label">Last station</string> | |||
| <string name="shortcut_last_station_long_label">Play last station</string> | |||
| <string name="shortcut_last_station_disabled_message">Shortcut for playback of last station disabled.</string> | |||
| <string name="shortcut_last_station_disabled_message">Removed shortcut for playback of last station.</string> | |||
There was a problem hiding this comment.
This isn't great
app/src/main/res/values/strings.xml
Outdated
| <!-- Allowed Template --> | ||
| <string name="allowed_caller_log"> | ||
| The caller has a valid certificate, but the wrong package for it. | ||
| To allow this caller, add the following to the allowed callers list:\n |
There was a problem hiding this comment.
Where is the "Allowed callers" list?
There was a problem hiding this comment.
I removed the whole string, since it causes errors, as you pointed out a while a ago.
See: aa9c7a8
There was a problem hiding this comment.
I removed it. Could be uncommenting it is better. It caused problems with XML checks over at Weblate.
No. That is the same. In the settings screen it is called: "Light mode". That's the easier to understand term, I guess. |
Untranslatable string spotted by @NathanBnm https://hosted.weblate.org/translate/transistor/strings/nb_NO/?checksum=9c1d94904dd3ca43 :)
'Day mode' is different from "light mode"?