Feature / Fix?: Follow the system theme #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I set the default to following the system theme. |
|
You should run |
|
LGTM on the whole. I wonder if @xou816 had a reason to make it the way it currently is. IMO it looks better to have a "theme" property than a "prefers-dark" for clarity. |
|
thanks for the review Diegovsky :) and thanks for the contribution ctsk! let's rebase and see how the ci goes |
The theme preference now an enum with 3 options:
- light => maps to libadwaita::ColorScheme::ForceLight
The app uses the light theme - regardless of system prefs
- dark => maps to libadwaita::ColorScheme::ForceDark
The app uses the dark theme - regardless of system prefs
- system => maps to libadwaita::ColorScheme::Default
The Apps style follows the system theme preferences
xou816
force-pushed
the
feat/system-theme
branch
from
a3ada23
to
10c2c6d
Compare
|
looks like it works perfectly, thanks for your patience!! merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The theme preference is now represented by an enum with 3 values:
light => maps to libadwaita::ColorScheme::ForceLight
The app uses the light theme - regardless of system prefs
dark => maps to libadwaita::ColorScheme::ForceDark
The app uses the dark theme - regardless of system prefs
system => maps to libadwaita::ColorScheme::Default
The Apps style follows the system theme preferences
Result