Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: option to follow system theme #515

Closed
pesader opened this issue May 1, 2022 · 5 comments
Closed

Feature request: option to follow system theme #515

pesader opened this issue May 1, 2022 · 5 comments

Comments

@pesader
Copy link

pesader commented May 1, 2022

Hi! Would it be possible to add a "Follow system theme" option to the settings? It could change the gsettings prefers-dark-theme to false, as you mentioned here.

I got that Spot stays dark intentionally, but I'd love to have light/dark consistency especially now that Dark Mode is officially a thing on GNOME 42. Take a look, I think it makes Spot feel even more "at home" on GNOME:

Light Dark
image image

Thanks a lot for developing Spot!!

@Diegovsky
Copy link
Collaborator

I was about to comment you can toggle that on Preferences but it did not work for me lol

@iGadget
Copy link

iGadget commented Aug 8, 2022

I was about to comment you can toggle that on Preferences but it did not work for me lol

Same here on Pop!_OS 22.04 (using Light theme) / Flatpak 0.3.3 - when I set the Theme to 'Dark' in the preferences, it does not change to dark. I'm guessing this a bug?

@Diegovsky
Copy link
Collaborator

Must be. If I have the time I'll open a pull request. It might take a while so if you know rust, feel free to open a pull request

@ctsk
Copy link
Contributor

ctsk commented Sep 14, 2022

I had a go at it in #548

I still don't know why ColorScheme::PreferDark / ColorScheme::PreferLight do not respect system settings, but apparently ColorScheme::Default does.

The PR also changes the theme menu to have 3 options - Force Light theme, Force Dark theme, Follow System theme.

Let me know your thoughts!

@xou816
Copy link
Owner

xou816 commented Feb 18, 2023

fixed by #548

@xou816 xou816 closed this as completed Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants