Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/refactor user permissions #496

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Conversation

tsubik
Copy link
Collaborator

@tsubik tsubik commented Jun 19, 2024

Quick change for user permissions to not have to update_permissions for every user after some code change (that could be forgotten).

We only use managed permissions for backoffice managers, that's why it's better to use static role_permissions and not something saved in the database. In the database we will only save permissions overwrites, so all users except bo_managers will for now on have permissions as nil in the database.

@tsubik tsubik requested a review from santostiago June 19, 2024 12:07
Copy link
Contributor

@santostiago santostiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@tsubik tsubik merged commit 5c6c575 into develop Jun 25, 2024
4 checks passed
@tsubik tsubik deleted the chore/refactor-user-permissions branch June 25, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants