Feature/newsletter history #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsubik
force-pushed
the
feature/newsletter-history
branch
from
a10838d
to
54397f4
Compare
santostiago
approved these changes
Jun 3, 2024
| column :short_description | ||
| column I18n.t("active_admin.operator_documents_page.attachment") do |n| | ||
| link_to n.attachment.identifier, n.attachment.url if n.attachment.present? | ||
| end |
There was a problem hiding this comment.
we can also add a column of type image with the activeadmin_addons (in case it's useful).
There was a problem hiding this comment.
Nah, we don't need it ;)
app/admin/newsletter.rb
Outdated
| f.inputs I18n.t("active_admin.shared.translated_fields") do | ||
| f.input :force_translations_from, label: I18n.t("active_admin.shared.translate_from"), | ||
| as: :select, | ||
| collection: I18n.available_locales, |
There was a problem hiding this comment.
maybe sort them (I should do it in the observations as well).
| I18n.with_locale locale do | ||
| # Some UTF charactes returned by google API are HTML encoded |
| @@ -59,17 +59,44 @@ | |||
|
|
|||
| $stdout.puts "Syncing test data..." | |||
|
|
|||
| sample_file_base64 = "data:application/pdf;base64,#{Base64.encode64(File.read(File.join(Rails.root, "spec", "support", "files", "doc.pdf")))}" | |||
| sample_pdf_file = "data:application/pdf;base64,#{Base64.encode64(File.read(File.join(Rails.root, "spec", "support", "files", "doc.pdf")))}" | |||
There was a problem hiding this comment.
Is the seeds file still used?
There was a problem hiding this comment.
Of course, most of the test data are fixtures dumped from production. That is used to have some initial data for E2E tests.
tsubik
force-pushed
the
feature/newsletter-history
branch
from
54397f4
to
167e1f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding option to save previous newsletters in the database.