Feature/operator documents new notifications admin #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santostiago
approved these changes
May 8, 2024
| @@ -48,6 +48,11 @@ def attachment | |||
|
|
|||
| def attachment=(attachment) | |||
| @model.build_document_file(attachment: attachment) | |||
| # TODO: check if there is better workaround for this issue https://github.com/rails/rails/issues/49898 | |||
There was a problem hiding this comment.
Yeah, using too many AR callbacks could be a real trap in Rails project. Many times callbacks didn't work as expected.
| @@ -383,7 +383,7 @@ fr: | |||
| annexes: 'Annexes' | |||
| operator_document_id: "ID de document de l'opérateur" | |||
| with_deleted: 'Avec supprimé' | |||
| reason_label: "Raison de mettre le document comme “non applicable”" | |||
| reason_label: "Le document a été mis comme non applicable avec l'explication suivante" | |||
Base automatically changed from
feature/operator-documents-new-notifications
to
develop
May 8, 2024 11:10
6f02758
to
a8ef5b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send notification to operator's responsible admins about new pending document ready for review.
PT: https://www.pivotaltracker.com/story/show/187126374