Feature/remove monitor names translation #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santostiago
approved these changes
Apr 29, 2024
| FROM | ||
| observer_translations t | ||
| WHERE | ||
| o.id = t.observer_id and t.locale = 'en' |
There was a problem hiding this comment.
Maybe it's a good idea to run a query first just to confirm they all have names in English (and to check if the names are the same in French).
There was a problem hiding this comment.
I already did that on production.
There was a problem hiding this comment.
There was only a small difference for one observer, and Sophie said to take English name for it.
| @@ -10,7 +10,11 @@ | |||
| # | |||
| # It's strongly recommended that you check this file into your version control system. | |||
|
|
|||
| ActiveRecord::Schema[7.0].define(version: 2023_11_30_113839) do | |||
| ActiveRecord::Schema[7.1].define(version: 2024_04_23_144714) do | |||
| create_schema "tiger" | |||
There was a problem hiding this comment.
mmm.. what is this for?
There was a problem hiding this comment.
Dunno, new rails starts dumping this.
52b4616
to
54d5c44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitor/Observer names should not be translated. I'm also removing
organizationattribute as looks like it is very obsolete.PT: https://www.pivotaltracker.com/story/show/187407020