Fix missing observer in some observation mails #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santostiago
approved these changes
Apr 29, 2024
app/mailers/observation_mailer.rb
Outdated
| mail to: user.email, subject: I18n.t(subject_i18n_key, observer: @observer.name, id: observation.id) | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def observer | ||
| @observation.modified_user.observer | ||
| @observation.modified_user.observer || @observation.user&.observer || @observation.observers.first |
There was a problem hiding this comment.
and modified_user is never nil?
There was a problem hiding this comment.
Right, probably not, but just to be safe I will change it.
… then the one who created observation if none then first
df5aa3d
to
2e00419
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, for example when backoffice admin updates observation through observation tool the observer is missing from
modified_useras that user is of admin type and has no observer attached. In that case, we will use observer from the user who created observation if somehow that one is null then just use first observer from observation.PT: https://www.pivotaltracker.com/story/show/187390044