Feature/admin operator documents perform qc #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tsubik
commented
Mar 28, 2024
•
tsubik
commented
tsubik
force-pushed
the
feature/admin-operator-documents-perform-qc
branch
from
dde6344
to
23493aa
Compare
santostiago
approved these changes
Apr 29, 2024
| @@ -48,6 +49,7 @@ class OperatorDocument < ApplicationRecord | |||
|
|
|||
| validates :start_date, presence: {if: :document_file_id?} | |||
| validates :expire_date, presence: {if: :document_file_id?} | |||
| validates :admin_comment, presence: {if: :doc_invalid?} | |||
There was a problem hiding this comment.
maybe we'll have issues if someone wants to update an old doc that is invalid.
But ok, maybe they shouldn't update it.
There was a problem hiding this comment.
True, I will double-check this if this is something to worry about.
tsubik
force-pushed
the
feature/admin-operator-documents-perform-qc
branch
from
ecdd106
to
76ec6e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.