Assign observers from observation report #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmm... interesting... |
santostiago
approved these changes
Jan 18, 2024
| @@ -25,17 +25,27 @@ class ObservationReport < ApplicationRecord | |||
| # API creating report fails as it's not providing user. Thing to investigate | |||
| belongs_to :user, inverse_of: :observation_reports, optional: true | |||
| has_many :observation_report_observers, dependent: :destroy | |||
| has_many :observers, through: :observation_report_observers | |||
| has_many :observers, through: :observation_report_observers, after_add: :self_touch, after_remove: :self_touch | |||
There was a problem hiding this comment.
mmmm.. I didn't know after_add and after_remove existed.
Cool!
| touch unless destroyed? || new_record? | ||
| end | ||
|
|
||
| def sync_observation_observers |
There was a problem hiding this comment.
I'm guessing in the future this won't be needed.
spec/factories/observations.rb
Outdated
| @@ -86,10 +47,10 @@ | |||
| severity { build(:severity, subcategory: subcategory) } | |||
| operator { create(:operator, country: country) } | |||
| observation_type { "operator" } | |||
| observers { build_list(:observer, 1) } | |||
| species { build_list(:species, 1, name: "Species #{Faker::Lorem.sentence}") } | |||
| # species { build_list(:species, 1, name: "Species #{Faker::Lorem.sentence}") } | |||
There was a problem hiding this comment.
mmm.. I think we can remove this.
spec/factories/observations.rb
Outdated
| severity | ||
| country | ||
| governments { build_list(:government, 2) } | ||
| # species { build_list(:species, 1, name: "Species #{Faker::Lorem.sentence}") } |
|
Observation without report is only possible in "Created" state, which I would say should be named as "Draft" lol. In fact, we are missing all those required fields validations in the backend. |
tsubik
force-pushed
the
fix/observation_report_observers
branch
2 times, most recently
from
dc17fa8
to
74673d0
Compare
…rvations having the same report
tsubik
force-pushed
the
fix/observation_report_observers
branch
from
74673d0
to
f6858c4
Compare
tsubik
force-pushed
the
fix/observation_report_observers
branch
from
1cfb9cf
to
78f83e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observation report should be the main source of observers for the observation.
Main changes:
We can keep the existing observation-observers relation for now, as changing this (removing that connection) could take a way more time. Changing API, and both applications to not seek observers in observation model but in observation report.