Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More cleanup #473

Merged
merged 7 commits into from
Dec 8, 2023
Merged

More cleanup #473

merged 7 commits into from
Dec 8, 2023

Conversation

tsubik
Copy link
Collaborator

@tsubik tsubik commented Nov 30, 2023 •
edited
Loading

  • Remove comments (it is not used, and not planned to use)
  • improve API
  • updating gems, especially carrierwave to v3

@tsubik tsubik force-pushed the feat/more-cleanup branch 4 times, most recently from 88d3a25 to 8aa3350 Compare December 1, 2023 09:06
santostiago
santostiago approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@santostiago santostiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fetch_all isn't used by the JsonAPIResources?

@tsubik
Copy link
Collaborator Author

tsubik commented Dec 8, 2023

No, it was introduced at the beginning, before the API gem.

@tsubik tsubik merged commit 763b65a into develop Dec 8, 2023
3 checks passed
@tsubik tsubik deleted the feat/more-cleanup branch December 8, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santostiago santostiago santostiago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsubik @santostiago