Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGO users can manage operators/gov entities #465

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

tsubik
Copy link
Collaborator

@tsubik tsubik commented Oct 30, 2023

As in the title. Pivotal story here: https://www.pivotaltracker.com/story/show/185881210

@tsubik tsubik force-pushed the feature/ngo-user-able-to-manage-producers-govs branch from ec7bf62 to 1d5ce38 Compare November 8, 2023 14:58
@tsubik tsubik force-pushed the feature/ngo-user-able-to-manage-producers-govs branch from 1d5ce38 to 157ebd2 Compare November 8, 2023 15:53
Copy link
Contributor

@santostiago santostiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but it's not enough.
You'll need to run a script to update the roles of the existing users.

@tsubik
Copy link
Collaborator Author

tsubik commented Nov 16, 2023

Thanks. Yes, I know that. I had to change that script in other PR to not update bo_manager users permissions. I think keeping user_permissions in this way in DB is bad idea and would gladly remove that model in the future. Keep abilities static, and only make certain abilities updatable for bo_managers but not ALL user permissions for all users, that makes no sense for me to always load this model.

@santostiago
Copy link
Contributor

@tsubik we shouldn't do that.
The individual users' permissions can still be edited in the Back Office on the permission matrix.
Most of the times the general settings are fine, but there were requirements to change permissions for specific users.

@santostiago
Copy link
Contributor

Oh, you mean to keep this only for BO Managers.
Yeah, that fine. But where do you want to save them?

@tsubik
Copy link
Collaborator Author

tsubik commented Nov 17, 2023

I thought that this access control should be directly in user's details in the admin panel not separately. What's more, I don't think we need those extra permissions to be in a separate table, the new data which won't have all permissions just couple overrides is not that heavy.

@tsubik tsubik merged commit 413f944 into develop Nov 17, 2023
3 checks passed
@tsubik tsubik deleted the feature/ngo-user-able-to-manage-producers-govs branch November 17, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants