Chore/rails 7 #436
Merged
Chore/rails 7 #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsubik
force-pushed
the
chore/rails-7
branch
2 times, most recently
from
2ac1d62
to
297c63b
Compare
santostiago
approved these changes
Apr 16, 2023
| @@ -2,4 +2,4 @@ | |||
|
|
|||
| # Specify a serializer for the signed and encrypted cookie jars. | |||
| # Valid options are :json, :marshal, and :hybrid. | |||
| Rails.application.config.action_dispatch.cookies_serializer = :marshal | |||
| Rails.application.config.action_dispatch.cookies_serializer = :hybrid | |||
There was a problem hiding this comment.
Because marshal does not work anymore, at least I have errors when saving filters in active admin. We should move to json after some time, hybrid is just temporal.
There was a problem hiding this comment.
Not mentioning brakeman ignored warnings when using marshal that could be silenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.