Chore/jsonapi upgrade to 0.9.12 #420
Conversation
| @@ -1,9 +1,5 @@ | |||
| module V1 | |||
| class BaseResource < JSONAPI::Resource | |||
| abstract | |||
|
|
|||
There was a problem hiding this comment.
We don't need this anymore? It doesn't include the custom links by default?
| @@ -7,6 +7,8 @@ | |||
| config.maximum_page_size = 3000 | |||
| config.resource_cache = Rails.cache | |||
| config.always_include_to_one_linkage_data = false | |||
| config.warn_on_missing_routes = false | |||
| config.default_exclude_links = :default | |||
There was a problem hiding this comment.
Yes, here is the default_exclude_links that removes links. Although, as this gem is so unstable across different versions it's always better to check if it works ;]
|
What issues did you run into when trying to move to 0.10? |
|
I don't even want to start talking about it. 0.10 is rewrite of crucial components and in that version or maybe master, don't even remember now, either STI works differently, or stops including nested relations or any relations in |
Upgrading jsonapi resources to newest 0.9 version which has Rails 6.1 support.
Note: I tried both master and 0.10 branch of jsonapi resources and always had different issues. I'm tired of this library, but creating API from scratch using for example jsonapi serializer is a big task at this point.
I tested that with both frontend apps using automated Cypress tests and all looked good. Will push this to staging soon to have it there for a while.