Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple middleware for health check #408

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Add simple middleware for health check #408

merged 1 commit into from
Feb 6, 2023

Conversation

tsubik
Copy link
Collaborator

@tsubik tsubik commented Feb 1, 2023

This will include more checks in the future.

santostiago
santostiago approved these changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@santostiago santostiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmm.. isn't there a gem for this?
(And why the commented Redis check?)

@tsubik
Copy link
Collaborator Author

tsubik commented Feb 6, 2023

As we don't use redis yet. Will uncomment it when we use action jobs with sidekiq, but I'm still not sure if sidekiq for this app is not overkill.

@tsubik
Copy link
Collaborator Author

tsubik commented Feb 6, 2023

Also, no need to add gem for a couple lines of code.

@tsubik tsubik merged commit d42f2cd into develop Feb 6, 2023
@tsubik tsubik deleted the feature/healthcheck-middleware branch February 6, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santostiago santostiago santostiago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsubik @santostiago