Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backoffice: enhance displaying versions #391

Merged
merged 5 commits into from
Jan 20, 2023

Conversation

tsubik
Copy link
Collaborator

@tsubik tsubik commented Jan 11, 2023

Display error message instead 500 page when paper trail reify did not work. We cannot run reify on create paper trail versions (according to documentation and also that returns just nil), that's why we only try to reify update, destroy events.

When object let's say Producer is created then Versionate sidebar will show that there are no other versions for this object. After every update there will be a new version, version = 0 is the first version.

@tsubik tsubik force-pushed the chore/refactor-aa-version-management branch 2 times, most recently from 49e46cc to 462b9cd Compare January 11, 2023 15:37
@tsubik tsubik marked this pull request as ready for review January 11, 2023 16:47
@tsubik
Copy link
Collaborator Author

tsubik commented Jan 14, 2023

Moving this to draft for now. I need to refactor showing up first version.

@tsubik
Copy link
Collaborator Author

tsubik commented Jan 14, 2023

Hmm, I dont' see "Draft" option anymore, not sure why.

@tsubik tsubik added WIP Work in Progress and removed WIP Work in Progress labels Jan 14, 2023
Copy link
Contributor

@santostiago santostiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tsubik tsubik force-pushed the chore/refactor-aa-version-management branch from cb18447 to d7d80ab Compare January 20, 2023 10:30
@tsubik tsubik merged commit 22b7a39 into develop Jan 20, 2023
@tsubik tsubik deleted the chore/refactor-aa-version-management branch January 20, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants