Fixing back Redirectable #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santostiago
reviewed
Dec 22, 2022
| redirect_to redirect, notice: "#{resource.model_name.human} was successfully updated." | ||
| end | ||
| end | ||
| update! { params[:return_to] || collection_path } |
There was a problem hiding this comment.
This won't return to the previous page on failure?
There was a problem hiding this comment.
This shortcut is described here https://github.com/activeadmin/inherited_resources#overwriting-actions
santostiago
reviewed
Dec 22, 2022
| if block.present? | ||
| extended = Proc.new do |f| | ||
| return_to = request.params[:return_to] || request.referer | ||
| f.hidden_field :return_to, name: :return_to, value: return_to if return_to.present? |
There was a problem hiding this comment.
shouldn't it be also disabled so that it's not sent in the form params?
There was a problem hiding this comment.
this must be sent back to controller (saved between requests) via params in this case. Otherwise, it won't work after validation errors. That's why I first check params[:return_to] if there is a value.
|
It should be sent with forms params, that the trick to save it between
validation errored requests. As for redirect shortcut I took it from
inherited resources documentation so it should be good.
…On Thu, Dec 22, 2022, 20:58 Tiago Santos ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/controllers/concerns/back_redirectable.rb
<#381 (comment)>:
>
+ def form(options = {}, &block)
+ if block.present?
+ extended = Proc.new do |f|
+ return_to = request.params[:return_to] || request.referer
+ f.hidden_field :return_to, name: :return_to, value: return_to if return_to.present?
shouldn't it be also disabled so that it's not sent in the form params?
—
Reply to this email directly, view it on GitHub
<#381 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ2CLCQ3W5EUGPP73H6RHLWOSXGNANCNFSM6AAAAAAS4JV5DE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
santostiago
reviewed
Dec 22, 2022
| super | ||
| end | ||
|
|
||
| def self.extended(base) |
There was a problem hiding this comment.
this gets evaluated just by extending the module?
santostiago
approved these changes
Dec 22, 2022
|
Yeah, first time I use that to be honest.
…On Thu, Dec 22, 2022, 21:02 Tiago Santos ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/controllers/concerns/back_redirectable.rb
<#381 (comment)>:
> @@ -1,36 +1,28 @@
# frozen_string_literal: true
module BackRedirectable
- def back_redirect
- controller do
- def edit
- session[:return_to] ||= request.referer
- super
- end
-
- def new
- session[:return_to] ||= request.referer
- super
- end
-
+ def self.extended(base)
this gets evaluated just by extending the module?
—
Reply to this email directly, view it on GitHub
<#381 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ2CLDXM7PYT3BJH2L3OOTWOSXUNANCNFSM6AAAAAAS4JV5DE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Sorry looks like responding via email is not great as it responds to main thread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little hacky, but looks like it works.
Story: https://www.pivotaltracker.com/story/show/183760908